Skip to content

Run typechecking in CI again #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sh4nks merged 5 commits into from
Apr 20, 2026
Merged

Run typechecking in CI again #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec36034
Run typechecking in CI again
rnestler Apr 20, 2026
fd9c503
Add types-uwsgi typing dependency
rnestler Apr 20, 2026
dde8616
mypy: Ignore missing imports
rnestler Apr 20, 2026
01ad70d
Add types-redis typing dependency
rnestler Apr 20, 2026
5acdf25
Don't run pyright typechecker
rnestler Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
- { python: "3.12" }
- { python: "3.11" }
- { python: "3.10" }
- { name: "typing", tox: "typing", python: "3.14" }
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: astral-sh/setup-uv@v7
Expand Down
10 changes: 9 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ typing = [
"mypy",
"pyright",
"pytest",
"types-redis>=4.6.0.20241004",
"types-uwsgi>=2.0.0.20260408",
]
gha-update = [
"gha-update ; python_full_version >= '3.12'",
Expand Down Expand Up @@ -154,6 +156,13 @@ warn_unused_ignores = true
strict_equality = true
strict_concatenate = true

[[tool.mypy.overrides]]
module = [
"pylibmc",
"google.*",
]
ignore_missing_imports = true

[tool.pyright]
pythonVersion = "3.10"
include = ["src"]
Expand Down Expand Up @@ -194,7 +203,6 @@ description = "run static type checkers"
dependency_groups = ["typing"]
commands = [
["mypy"],
["pyright"],
Copy link
Copy Markdown
Contributor Author

@rnestler rnestler Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyright currently shows quite some type checking errors. Since I don't have much experience with it I just removed it for now.

I think getting one type checker to run successfully in strict mode should be the first priority. Adding more afterwards can still be helpful.

]

[tool.tox.env.docs]
Expand Down
Loading
Loading