Skip to content

GH1795 Add pyrefly coverage step - #1883

Open
loicdiridollou wants to merge 1 commit into
pandas-dev:mainfrom
loicdiridollou:gh1795_pyrefly_coverage
Open

GH1795 Add pyrefly coverage step#1883
loicdiridollou wants to merge 1 commit into
pandas-dev:mainfrom
loicdiridollou:gh1795_pyrefly_coverage

Conversation

@loicdiridollou

Copy link
Copy Markdown
Member

Adding pyrefly coverage, needed a few tweaks for the data at the top of test files but this is now looking quite good.

@loicdiridollou
loicdiridollou requested a review from cmp0xff August 8, 2026 23:26
@loicdiridollou

Copy link
Copy Markdown
Member Author

@MarcoGorelli

Tried to add pyrefly coverage to the stubs, interesting failure on the 3.11 versions, let me know if you have some background, yes it is much faster but is it worth the hassle to maintain, not totally convinced.

@cmp0xff

cmp0xff commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  • It seems worthy reporting to ty
  • You can try if sys.python_version: ...
  • Alternatively you can use # ty: ignore[invalid-assignment,unused-ignore-comment,unused-ignore-comment] to bypass

@MarcoGorelli

Copy link
Copy Markdown
Member

thanks for the ping! i was looking at this recently, i think there may a simpler way to do it, will update you

@MarcoGorelli

Copy link
Copy Markdown
Member

I've pushed to https://github.com/pandas-dev/pandas-stubs/compare/main...MarcoGorelli:pyrefly-coverage-check?expand=1

It bumps pyrefly to 1.2.0, so that the tool.pyrefly.coverage section in pyproject.toml can be used. I've excluded tests and am using the --public-only flag, so that the rest can all stay the same

Note that #1819 added missing annotations brought up by pyrefly coverage check, and that's already been merged, so that's why nothing else needs changing now

If you agree, do you want to cherry-pick from my branch and update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_completeness checks are timing out

3 participants