Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ipython & ipywidgets v8 #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow ipython & ipywidgets v8 #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ requires-python = ">=3.6,<3.11"
requires = [
"dataclasses==0.8; python_version == '3.6'",
"filelock>=3.0",
"ipython>=5.5.0,<8.0",
"ipywidgets>=7.0.0,<8.0",
"ipython>=5.5.0,<9.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give this a spin, but a major version bump could mean disaster. Have you reviewed the changelogs? Especially of ipywidgets? It's generally good form to have done so and reported that in either the change description or a PR comment. Right now we just hope we're getting lucky and the existing tests catch any API breaks the upgrade triggers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - wasn't sure about the test coverage/how best to smoke-test. I'll take a look at the changelogs for ipywidgets and circle back.

"ipywidgets>=7.0.0,<9.0",
"nest_asyncio~=1.5.1",
"requests>=2.22.0",
"twitter.common.contextutil~=0.3.11",
Expand Down