Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: stabilize test_shell_command target type #22016

Merged
merged 6 commits into from
Mar 2, 2025

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Feb 26, 2025

Stabilize the test_shell_command target type.

@tdyas tdyas requested review from huonw and thejcannon February 26, 2025 21:34
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than:

Thanks for getting this ready.

Co-authored-by: Huon Wilson <[email protected]>
@tdyas
Copy link
Contributor Author

tdyas commented Feb 28, 2025

The chroot substitution issue is just a display issue due to the test goal's "output simplifier." The issue affects all tests and not just test_shell_command, so it should not be relevant to stabilizing test_shell_command.

@tdyas tdyas requested a review from huonw February 28, 2025 21:00
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! thanks for confirming.

@tdyas tdyas merged commit a5b2e7d into pantsbuild:main Mar 2, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants