-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: stabilize test_shell_command
target type
#22016
shell: stabilize test_shell_command
target type
#22016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than:
- the deprecation period
- confirmation of the resolution for the outstanding item stabilize
experimental_test_shell_command
astest_shell_command
#21982 / chroot substitution is inconsistent with experimental_test_shell_command #22014. My understanding is that doc updates here are the appropriate resolution?
Thanks for getting this ready.
Co-authored-by: Huon Wilson <[email protected]>
The chroot substitution issue is just a display issue due to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! thanks for confirming.
Stabilize the
test_shell_command
target type.