shell: stabilize test_shell_command target type

BUILD

@@ -35,7 +35,7 @@ files(
 )
 
 # NB: This should be in `lint` when we implement `lint` in https://github.com/pantsbuild/pants/issues/17729
-experimental_test_shell_command(
+test_shell_command(
     name="checks-empty-init-files",
     command="""
         NONEMPTY_INITS=$(find . -type f -name "*.py" -size +0);

docs/notes/2.26.x.md

@@ -89,7 +89,7 @@ A bug in the Django backend has been fixed so that a repo may have no Django app
 
 #### Shell
 
-The `experiemental_test_shell_command` target type learned several new features:
+The `experiemental_test_shell_command` target type is no longer experimental and is stabilized as the `test_shell_command` target type. As part of stablilizing it, `test_shell_command` learned several new features:
 
 - It now supports the `test` goal's `--debug` flag to execute tests interactively.
 - Outputs may now be captured as test "extra outputs" as specified by the new `output_files`, `output_directories`, `root_output_directory`, and `outputs_match_mode` fields. (These fields operate in the same manner as for the `shell_command` target type.) Captured output will be written in a directory under `dist/` based on the target name when a test completes.

src/python/pants/backend/shell/goals/test_test.py

@@ -72,14 +72,14 @@ def test_basic_usage_of_test_shell_command(rule_runner: RuleRunner) -> None:
                   output_files=["msg.txt"],
                 )
 
-                experimental_test_shell_command(
+                test_shell_command(
                   name="pass",
                   execution_dependencies=[":msg-gen", ":src"],
                   tools=["echo"],
                   command="./test.sh msg.txt message",
                 )
 
-                experimental_test_shell_command(
+                test_shell_command(
                   name="fail",
                   execution_dependencies=[":msg-gen", ":src"],
                   tools=["echo"],
@@ -96,7 +96,7 @@ def test_basic_usage_of_test_shell_command(rule_runner: RuleRunner) -> None:
                     binary_name="test",
                     fingerprint_args=["1", "=", "1"]
                 )
-                experimental_test_shell_command(
+                test_shell_command(
                   name="pass_with_runnable_dependency",
                   execution_dependencies=[":msg-gen", ":src"],
                   tools=["echo"],
@@ -164,7 +164,7 @@ def test_extra_outputs_support(rule_runner: RuleRunner) -> None:
                 """\
                 shell_sources(name="src")
 
-                experimental_test_shell_command(
+                test_shell_command(
                   name="test",
                   execution_dependencies=[":src"],
                   tools=["echo", "mkdir"],
@@ -205,38 +205,38 @@ def test_outputs_match_mode_support(rule_runner: RuleRunner) -> None:
         {
             "BUILD": dedent(
                 """\
-            experimental_test_shell_command(
+            test_shell_command(
                 name="allow_empty",
                 command="true",
                 output_files=["non-existent-file"],
                 output_directories=["non-existent-dir"],
                 outputs_match_mode="allow_empty",
             )
-            experimental_test_shell_command(
+            test_shell_command(
                 name="all_with_present_file",
                 command="touch some-file",
                 tools=["touch"],
                 output_files=["some-file"],
                 output_directories=["some-directory"],
                 outputs_match_mode="all",
             )
-            experimental_test_shell_command(
+            test_shell_command(
                 name="all_with_present_directory",
                 command="mkdir some-directory",
                 tools=["mkdir"],
                 output_files=["some-file"],
                 output_directories=["some-directory"],
                 outputs_match_mode="all",
             )
-            experimental_test_shell_command(
+            test_shell_command(
                 name="at_least_one_with_present_file",
                 command="touch some-file",
                 tools=["touch"],
                 output_files=["some-file"],
                 output_directories=["some-directory"],
                 outputs_match_mode="at_least_one",
             )
-            experimental_test_shell_command(
+            test_shell_command(
                 name="at_least_one_with_present_directory",
                 command="mkdir some-directory && touch some-directory/foo.txt",
                 tools=["mkdir", "touch"],

src/python/pants/backend/shell/target_types.py

@@ -486,7 +486,11 @@ class ShellCommandRunTarget(Target):
 
 
 class ShellCommandTestTarget(Target):
-    alias = "experimental_test_shell_command"
+    alias = "test_shell_command"
+
+    deprecated_alias = "experimental_test_shell_command"
+    deprecated_alias_removal_version = "2.29.0.dev0"
+
     core_fields = (
         *COMMON_TARGET_FIELDS,
         ShellCommandTestDependenciesField,
@@ -512,15 +516,15 @@ class ShellCommandTestTarget(Target):
 
         Example BUILD file:
 
-            experimental_test_shell_command(
+            test_shell_command(
                 name="test",
                 tools=["test"],
                 command="test -r $CHROOT/some-data-file.txt",
                 execution_dependencies=["src/project/files:data"],
             )
 
-        The `command` may use either `{chroot}` on the command line, or the `$CHROOT`
-        environment variable to get the root directory for where any dependencies are located.
+        The `command` may use the `{chroot}` marker on the command line or in environment variables
+        to get the root directory where any dependencies are materialized during execution.
 
         In contrast to the `run_shell_command`, this target is intended to run shell commands as tests
         and will only run them via the `test` goal.

src/rust/engine/BUILD

@@ -55,7 +55,7 @@ files(
 )
 
 # NB: This should be in `lint` when we implement `lint` in https://github.com/pantsbuild/pants/issues/17729
-experimental_test_shell_command(
+test_shell_command(
     name="checks-rust-banned-imports",
     command=f"""
         BAD_FILES=$(grep -r -l -E "^use std::sync::.*(Mutex|RwLock)" {build_file_dir()});