fix: js/ts dependency inference with file suffix #22041
Conversation
| @@ -166,7 +166,7 @@ def _add_extensions(file_imports: frozenset[str], file_extensions: tuple[str, .. | |||
| for file_import in file_imports | |||
| for string in ( | |||
| [file_import] | |||
| if PurePath(file_import).suffix | |||
| if PurePath(file_import).suffix and PurePath(file_import).suffix in file_extensions | |||
There was a problem hiding this comment.
When we had a file like foo.<suffix>.js, foo.<suffix> was being added to the PathGlobs, but that file doesn't exist, the correct would be to fallback to the else statement and use foo.<suffix>.(<file_extensions>), so I'm adding a check to make sure the suffix is what we would expect coming from the parameters (all js/ts extensions depending on each dependency inference).
| rule_runner.write_files( | ||
| { | ||
| "root/project/src/__generated__/BUILD": "javascript_sources()", | ||
| "root/project/src/__generated__/moduleA.generated.js": "", |
There was a problem hiding this comment.
.generated.js is one use case, but any suffix should be handled correctly.
src/python/pants/backend/javascript/dependency_inference/rules.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/javascript/dependency_inference/rules.py
Outdated
Show resolved
Hide resolved
|
macos test suite failed with: can we re-run? |
|
May I assume this should be backported to the |
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.25.xSuccessfully opened #22056. Thanks again for your contributions! |
…) (#22056) # Description Its possible that we have a file like `foo.<suffix>.js`, but when importing that file on another .js file, dependency inference wasn't working. Co-authored-by: Kevin Oliveira <[email protected]>
Description
Its possible that we have a file like
foo.<suffix>.js, but when importing that file on another .js file, dependency inference wasn't working.