Fix incorrect path in error message. #22060
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make two essentially identical errors have a consistent message phrasing.
benjyw
added
the
release-notes:not-required
benjyw
commented
Mar 9, 2025
| .await | ||
| .map_err(|e| format!("Error setting permissions on {}: {e}", path.display()))?; |
There was a problem hiding this comment.
path is irrelevant here, it's destination we're setting permissions on...
tdyas
approved these changes
Mar 9, 2025
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.25.xSuccessfully opened #22061. Thanks again for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make two essentially identical errors
have a consistent message phrasing.