Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect path in error message. #22060

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Fix incorrect path in error message. #22060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/rust/engine/fs/store/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,9 +1308,8 @@ impl Store {
.await
.map_err(|e| {
format!(
"Failed to set permissions for {}: {}",
"Error setting permissions on {}: {e}",
destination.display(),
e
)
})?;
}
Expand Down Expand Up @@ -1366,9 +1365,14 @@ impl Store {
destination.display()
)
})?;
tokio::fs::set_permissions(destination, FSPermissions::from_mode(mode))
tokio::fs::set_permissions(&destination, FSPermissions::from_mode(mode))
.await
.map_err(|e| format!("Error setting permissions on {}: {e}", path.display()))?;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path is irrelevant here, it's destination we're setting permissions on...

.map_err(|e| {
format!(
"Error setting permissions on {}: {e}",
destination.display()
)
})?;
Ok(())
}
None => {
Expand Down
Loading