Upgrade rubocop + rubocop plugins #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
davidrunger
reviewed
Mar 31, 2025
fatkodima
reviewed
Mar 31, 2025
fatkodima
reviewed
Mar 31, 2025
davidrunger
reviewed
Apr 1, 2025
There was a problem hiding this comment.
This looks solid to me. I largely agree with @fatkodima 's comments about some of the cops that might be better to disable rather than to autocorrect and enforce.
|
i'll make one more pass and try to revert the rules mentioned above. if it's not straightforward i'll have to abandon this attempt - i have very little time today to work on this and i don't want bike shedding to block the real reason i did this (#1514). |
…er_spec_type_from_file_location! to rspec
|
ok, i've addressed + fixed all the previous issues. if i don't hear anything else back in the next day i'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr upgrades
rubocopto the most recent version. it also upgrades the various plugins we use to the most recent compatible versions. this unblocks #1513 (which requires a newer version ofrubocopto support ruby 3.4).this pr includes all of the safe fixes (via
rubocop -a) exceptGemspec/RequireMFA(i'm not sure who has access to this onrubygemsso i didn't want to lock anyone out).all other errors were added to
.rubocop_todo.ymlviarubocop --auto-gen-config.master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.