fix: built-in ArgumentError in tokenizer - #107
Merged
Merged
Conversation
philippemnoel
requested review from
isaacvando,
mdashti,
rebasedming and
stuhood
as code owners
June 15, 2026 01:41
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 20 20
Lines 2404 2404
Branches 710 710
=======================================
Hits 2172 2172
Misses 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- tokenizer.rb: render_positional_arg raised the undefined constant InvalidArgumentError (no such constant is defined anywhere in the gem), which would itself raise NameError at runtime instead of the intended argument error. Use Ruby's built-in ArgumentError.
isaacvando
force-pushed
the
fix/tokenizer-error-and-ddl-note
branch
from
June 15, 2026 14:34
4059c42 to
74de739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug —
NameErrorinstead of the intended argument error (lib/parade_db/tokenizer.rb:92)Tokenizer#render_positional_argraisedInvalidArgumentErrorfor unsupported arg types:InvalidArgumentErroris not defined anywhere in the gem (verified viagrep -rn "InvalidArgumentError"— the only hit was this line). At runtime Ruby would raiseNameError: uninitialized constant ...instead of a meaningful argument error, masking the real problem.Fix: use Ruby's built-in
ArgumentError. This matches how the rest ofmigration_helpers.rbalready raisesArgumentErrorfor bad tokenizer args.