Skip to content

[pallet-revive] Enforce weight limit on dry-run RPC calls #10902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pgherveou wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[pallet-revive] Enforce weight limit on dry-run RPC calls #10902

pgherveou wants to merge 3 commits into from

Conversation

@pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Jan 26, 2026 •
edited
Loading

Summary

  • Makes the weight_limit field in TransactionLimits::EthereumGas non-optional, enforcing bounded execution on all Ethereum-style calls
  • Updates dry_run_eth_transact to use evm_max_extrinsic_weight() as the weight limit, preventing unbounded computation during dry-run RPC calls
  • Simplifies metering code by removing Option handling for weight limits in Ethereum execution mode

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jan 26, 2026

User @claude, please sign the CLA here.

@0xRVE 0xRVE added the T7-smart_contracts This PR/Issue is related to smart contracts. label Jan 26, 2026
@0xRVE
Copy link
Contributor

0xRVE commented Jan 26, 2026

/cmd prdoc --audience runtime_dev --bump patch

0xRVE
0xRVE requested changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@0xRVE 0xRVE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs to be fixed

TorstenStueber
TorstenStueber approved these changes Jan 30, 2026
View reviewed changes
substrate/frame/revive/src/lib.rs
// no need to limit weight here, we will check later whether it exceeds
// evm_max_extrinsic_weight
maybe_weight_limit: None,
weight_limit: Self::evm_max_extrinsic_weight(),
Copy link
Contributor

@TorstenStueber TorstenStueber Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only crucial change in this PR, the other changes are all logically implied when changing from optional weight to weight.

This change looks good to me but I was not sure for a second whether this also needs to cover the deposit cost. But I remember it doesn't (please confirm).

Copy link
Contributor Author

@pgherveou pgherveou Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Away from keyboard will check in a bit

Copy link
Contributor Author

@pgherveou pgherveou Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in Substrate mode weight and deposit are tracked separetly

@pgherveou pgherveou enabled auto-merge January 30, 2026 13:05
@pgherveou
Copy link
Contributor Author

pgherveou commented Jan 30, 2026

/cmd prdoc --audience runtime_dev --bump patch

@paritytech-workflow-stopper
Copy link

paritytech-workflow-stopper bot commented Jan 30, 2026

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21517076337
Failed job name: cargo-clippy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenStueber TorstenStueber TorstenStueber approved these changes

@0xRVE 0xRVE 0xRVE approved these changes

Assignees

No one assigned

Labels

T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgherveou @0xRVE @TorstenStueber