Remove ForeignAssetId associated type from ForeignAssetsConfig #10945
+144
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the foreign assets precompile configuration by hardcoding the asset ID type to `Location` instead of using a generic associated type. This aligns with the actual usage in runtimes where foreign assets are always identified by XCM Locations. Changes: - Remove `ForeignAssetId` from `pallet::Config` trait - Update storage types to use `Location` directly - Update mock to use `Location` as `AssetId` for pallet_assets - Update tests to use `Location` instead of `u32`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ForeignAssetIdassociated type frompallet::Configtrait, hardcoding toLocationinsteadLocationdirectlyTest plan
Locationas asset ID