fix(revive): handle transaction hash conflicts during re-org #10950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a blockchain re-org occurs and the same transaction is included in a different block, the INSERT into transaction_hashes would fail with a UNIQUE constraint violation if the server had restarted (losing the in-memory block_number_to_hashes map used for pruning). This change uses INSERT OR REPLACE to update the block_hash when a transaction is re-included in a different block after a re-org, matching the pattern already used for insert_block_mapping. Fixes: UNIQUE constraint failed: transaction_hashes.transaction_hash
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
pgherveou
added
the
T7-smart_contracts
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
…time_dev --bump patch'
xermicus
approved these changes
Jan 30, 2026
marian-radu
approved these changes
Jan 30, 2026
0xRVE
reviewed
Jan 30, 2026
| // Transaction should now point to block B | ||
| let (found_hash, _) = provider.find_transaction(&tx_hash).await.unwrap(); | ||
| assert_eq!(found_hash, block_b.hash); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| assert_eq!(count(&provider.pool, "eth_to_substrate_blocks", None).await, 1); |
Or it is ok to have block A still sitting in the table?
Contributor
Author
There was a problem hiding this comment.
good point we can check in another PR, if we do clean up forked blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a UNIQUE constraint violation when processing blocks after a re-org:
Problem
When a blockchain re-org occurs:
transaction_hashesblock_number_to_hashesmap)