Add '-progress' option. Closes #30

[entrity]

Pursuant to #30, this commit adds a '-progress' option. If set to true, then a function pointer is passed to 'fillwithbytes', with the result that each iteration of the loop in that function outputs a progress update.

The progress update appears at the end of the current line and overwrites itself with each repetition, producing an output resembling the following:

Now eliminating candidates based on [...]: (16/19324)

(This PR is a recreation of #159. I had to address a merge conflict there while I was waiting on that PR to be reviewed, and it borked the checks on the PR.)

[entrity]

I understand that a similar PR is open: #42. That PR has merge conflicts which must be resolved.

Other differences between that PR and this one are:

• Added a -progress option to display the progress during elimination #42 passes a stream pointer; this pull-request passes a function pointer. I prefer this pull-request's implementation because the presenter logic is abstracted out of Rdutil::fillwithbytes and more easily replaced if someone wants a different format in the future
• Added a -progress option to display the progress during elimination #42 outputs progress as a percentage; this pull requests outputs progress as count / total. I prefer this pull-request's implementation because, as one of the comments on 42 points out, it can take a long time to see any update on 42 if the job is very large.
• Added a -progress option to display the progress during elimination #42 updates its output only once every 10k iterations; this pull-request updates its output every iteration. This one's a toss-up. I like the more frequent updates, but another user might prefer not to spend cycles on such frequent updates.
• Added a -progress option to display the progress during elimination #42 uses a carriage return \r to update the entire line; this pull-request saves the cursor location and just updates the numbers at the end of the line, i.e. the parenthetical in Now eliminating candidates based on [...]: (16/19324).

[entrity]

Hello, @pauldreik. Would you have a look at this solution for issue #30 ?

[entrity]

Hello, @trollkarlen. Would you review this solution for issue #30 ?

[entrity]

Hello, @mlissner . Would you review this solution for issue #30 ?

[mlissner]

Sorry, am I the right person to copy this on, @entrity?

[entrity]

Sorry, am I the right person to copy this on, @entrity?

Thanks for getting back to me @mlissner . I guess I don't know who has the ability to approve changes on this repo. I see that @pauldreik is the owner, but I haven't gotten any traction from @pauldreik . Do you have any advice on how to get my change merged?

[mlissner]

Not a clue. It's been years since I've done anything here.

[entrity]

Hi, @pauldreik . Would you review this pull request for issue #30?

[pauldreik]

sorry for being unresponsive, will try to have a look at this over the weekend.

[entrity]

Hi, @pauldreik. Here's a bump to prevent this from falling off your radar 💐

[entrity]

Hi, @pauldreik. Here's a bump to prevent this from falling off your radar 💐

[entrity]

Hi, @pauldreik. Here's a bump to prevent this from falling off your radar 💐

[alexmi256]

Is this diff missing ListProgress.hh/cc or are those supposed to be pulled in by another tool when configuring?

[entrity]

Thanks, @alexmi256. It looks as if my rebase + merge resolution went off track. I've now restored the missing files, built it again locally, run it again locally, and run make check successfully. 🙏

[entrity]

Hi, @pauldreik . Would you review this pull request for issue #30?

[entrity]

Hi, @pauldreik . Would you review this pull request for issue #30?

[entrity]

Hi, @pauldreik . Would you review this pull request for issue #30?

[entrity]

Hi, @pauldreik . Would you review this pull request for issue #30?

[entrity]

Hi, @pauldreik . Would you review this pull request for issue #30?

[entrity]

Hi, @pauldreik . Would you review this pull request for issue #30?

[pauldreik]

Thanks for your nice writeup and fixes! (And apologies for the world record delay.) Parts of this PR were incorporated into the devel branch just now.