fix: prevent crash when hmac key is longer than 64 bytes in picohash #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise any connection attempt with a ufrag longer than 64 characters causes the process to exit with a SIGBUS error.
achingbrain
commented
Feb 11, 2025
Co-authored-by: Paul-Louis Ageneau <[email protected]>
paullouisageneau
approved these changes
Feb 14, 2025
paullouisageneau
added a commit
that referenced
this pull request
Feb 14, 2025
fix: set hash_reset before invoking it
paullouisageneau
changed the title
paullouisageneau
changed the title
paullouisageneau
added a commit
that referenced
this pull request
Feb 14, 2025
fix: prevent crash when hmac key is longer than 64 bytes in picohash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise any connection attempt with a ufrag longer than 64 characters causes the process to exit with a SIGBUS error.
I have not been able to isolate this into a test, but at runtime it crashes the remote process every single time.