Skip to content

fix: prevent crash when hmac key is longer than 64 bytes in picohash #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025
Merged

fix: prevent crash when hmac key is longer than 64 bytes in picohash #295

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25181f1
fix: set hash_reset before invoking it
achingbrain Feb 11, 2025
3d89ed1
chore: whitespace
achingbrain Feb 11, 2025
2fa5988
chore: use picohash_reset
achingbrain Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/picohash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,7 @@ inline void picohash_init_hmac(picohash_ctx_t *ctx, void (*initf)(picohash_ctx_t
/* hash the key if it is too long */
picohash_update(ctx, key, key_len);
picohash_final(ctx, ctx->_hmac.key);
ctx->_hmac.hash_reset = ctx->_reset;
ctx->_hmac.hash_reset(ctx);
} else {
memcpy(ctx->_hmac.key, key, key_len);
Expand Down