Skip to content

Add Business Information Fields to Registration new #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

sundayonah
Copy link
Collaborator

Description

This PR implements enhanced user registration functionality by adding business-related fields and monthly volume tracking. These changes will help us better understand our users' transaction patterns and business profiles, enabling improved risk assessment and service customization.

Key changes include:

  • Added new fields to registration payload: monthly_volume, business_website, and nature_of_business
  • Implemented database migrations for storing monthly volume in both sender and provider profiles
  • Added validation logic for new fields
  • Integrated analytics tracking for registration metrics
  • Updated API documentation with new field descriptions

References

Closes #455

Testing

New unit tests have been added for:

  • Monthly volume validation (positive/negative values)
  • Business website URL validation
  • Nature of business field validation
  • Registration payload validation

Checklist

  • I have added documentation and tests for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

@sundayonah sundayonah requested review from chibie and 5ran6 as code owners April 29, 2025 23:49
sundayonah added 3 commits May 3, 2025 21:35
…elds to sender and provider profiles

- Added `monthly_volume` field to both ProviderProfile and SenderProfile schemas with validation.
- Introduced `business_website` and `nature_of_business` fields to SenderProfile schema with regex validation for URLs.
- Updated the corresponding Go structs and database handling methods to accommodate new fields.
- Implemented necessary predicates for querying based on the new fields.
- Enhanced the create and update methods to handle the new fields, including validation.
- Updated the RegisterPayload to include new fields for monthly volume, business website, and nature of business.
- Added utility functions for URL validation and monthly volume validation.
@chibie chibie force-pushed the feature/add-business-info-registration-new branch from eb6b5ef to f413526 Compare May 3, 2025 20:35
sundayonah added 7 commits May 8, 2025 09:07
- Reverted 20240905170202_sender_provider_id.sql
- Added extra_signup_fields migration
- Updated atlas.sum checksums
…elds to sender and provider profiles

- Added `monthly_volume` field to both ProviderProfile and SenderProfile schemas with validation.
- Introduced `business_website` and `nature_of_business` fields to SenderProfile schema with regex validation for URLs.
- Updated the corresponding Go structs and database handling methods to accommodate new fields.
- Implemented necessary predicates for querying based on the new fields.
- Enhanced the create and update methods to handle the new fields, including validation.
- Updated the RegisterPayload to include new fields for monthly volume, business website, and nature of business.
- Added utility functions for URL validation and monthly volume validation.
- Reverted 20240905170202_sender_provider_id.sql
- Added extra_signup_fields migration
- Updated atlas.sum checksums
@sundayonah sundayonah requested a review from chibie May 12, 2025 13:43
@sundayonah sundayonah requested a review from chibie May 14, 2025 09:19
@chibie chibie closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Business Information Fields to Registration
2 participants