Skip to content

Skip screenshot tests in CI #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 59 commits into from
Mar 6, 2024
Merged

Skip screenshot tests in CI #2348

merged 59 commits into from
Mar 6, 2024

Conversation

nbierdeman
Copy link
Contributor

@nbierdeman nbierdeman commented Feb 28, 2024

Description

This PR is a compromise, but a reasonable one, in my opinion. Jest screenshot tests pass locally, but fail in CI. Valiant attempts were made at fixing them (please see the commit history for excruciating detail), but it was ultimately decided by Product that it was time to move on. Instead, screenshot tests run locally in a pre-push hook, but are skipped in CI, including when git push is run in CI. Another way of thinking of these changes is every step in npm run test happens between the local pre-push hook and the GitHub Actions tasks. If all goes well, this should unblock publishing v4 using GitHub Actions.

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

DTPPCPSDK-1978

Screenshots

Here you can see the pre-push hook running screenshot tests locally:

Screenshot 2024-03-06 at 2 02 31 PM

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v4@6eca4ac). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v4    #2348   +/-   ##
=====================================
  Coverage      ?   69.17%           
=====================================
  Files         ?       92           
  Lines         ?     3105           
  Branches      ?      183           
=====================================
  Hits          ?     2148           
  Misses        ?      877           
  Partials      ?       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbierdeman nbierdeman changed the title Do not merge - this is just to test CI Skip screenshot tests in CI Mar 6, 2024
@nbierdeman nbierdeman requested a review from a team March 6, 2024 19:16
Copy link
Contributor

@jshawl jshawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a commendable effort and a clever compromise! :shipit:

@nbierdeman nbierdeman merged commit 9570661 into v4 Mar 6, 2024
2 checks passed
@nbierdeman nbierdeman deleted the fix-v4-ci branch March 6, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants