-
Notifications
You must be signed in to change notification settings - Fork 577
Skip screenshot tests in CI #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #2348 +/- ##
=====================================
Coverage ? 69.17%
=====================================
Files ? 92
Lines ? 3105
Branches ? 183
=====================================
Hits ? 2148
Misses ? 877
Partials ? 80 ☔ View full report in Codecov by Sentry. |
1f7550e
to
ca7e04f
Compare
5c6584e
to
2e858fd
Compare
2e858fd
to
e53676a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a commendable effort and a clever compromise!
Description
This PR is a compromise, but a reasonable one, in my opinion. Jest screenshot tests pass locally, but fail in CI. Valiant attempts were made at fixing them (please see the commit history for excruciating detail), but it was ultimately decided by Product that it was time to move on. Instead, screenshot tests run locally in a pre-push hook, but are skipped in CI, including when
git push
is run in CI. Another way of thinking of these changes is every step innpm run test
happens between the local pre-push hook and the GitHub Actions tasks. If all goes well, this should unblock publishingv4
using GitHub Actions.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
DTPPCPSDK-1978
Screenshots
Here you can see the pre-push hook running screenshot tests locally: