Skip screenshot tests in CI #2348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #2348 +/- ##
=====================================
Coverage ? 69.17%
=====================================
Files ? 92
Lines ? 3105
Branches ? 183
=====================================
Hits ? 2148
Misses ? 877
Partials ? 80 ☔ View full report in Codecov by Sentry. |
nbierdeman
force-pushed
the
fix-v4-ci
branch
from
1f7550e to
ca7e04f
Compare
nbierdeman
force-pushed
the
fix-v4-ci
branch
from
5c6584e to
2e858fd
Compare
nbierdeman
force-pushed
the
fix-v4-ci
branch
from
2e858fd to
e53676a
Compare
nbierdeman
changed the title
jshawl
approved these changes
Mar 6, 2024
Contributor
jshawl
left a comment
jshawl
left a comment
There was a problem hiding this comment.
a commendable effort and a clever compromise! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a compromise, but a reasonable one, in my opinion. Jest screenshot tests pass locally, but fail in CI. Valiant attempts were made at fixing them (please see the commit history for excruciating detail), but it was ultimately decided by Product that it was time to move on. Instead, screenshot tests run locally in a pre-push hook, but are skipped in CI, including when
git pushis run in CI. Another way of thinking of these changes is every step innpm run testhappens between the local pre-push hook and the GitHub Actions tasks. If all goes well, this should unblock publishingv4using GitHub Actions.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
DTPPCPSDK-1978
Screenshots
Here you can see the pre-push hook running screenshot tests locally: