-
Notifications
You must be signed in to change notification settings - Fork 580
Skip screenshot tests in CI #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+36
−12
Merged
Changes from 58 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
6c178b2
skip webpack
nbierdeman 78b30ef
ci failed -> webpack is cool again
nbierdeman 174356d
skip jest screenshot tests
nbierdeman 02c01e7
only run webpack and jest screenshot tests
nbierdeman 8ef2d1e
yep, jest screenshot tests break ci
nbierdeman 43a00f2
let's see what happens when grabthar-release is upgraded
nbierdeman 6fa35cb
seems like we're stuck with grabthar-release v1.0.69
nbierdeman ca7e04f
what happens when we remove an event listener?
nbierdeman 404a37d
the event listener was not the culprit
nbierdeman 14036cc
what if we run jest without the env option?
nbierdeman 80d668a
nah, the env option was fine
nbierdeman e53676a
try ci option
nbierdeman 0fc9f62
nah, the ci option didn't work
nbierdeman 009f491
add --help to jest
nbierdeman d84f2b8
yep, CI executes jest --help
nbierdeman 43dc38b
setup new gh actions task for jest screenshots
nbierdeman 5c121bc
remove flow since it keeps failing now that screenshots are a separat…
nbierdeman 544f639
the separate screenshot task still hung
nbierdeman bd1e77b
add screenshot test logs
nbierdeman ff06bce
add more screenshot logs
nbierdeman 21b02db
even more screenshot logs
nbierdeman 7ddac55
start from the top
nbierdeman 05d5a0f
remove npm run buttondiff from 'test'
nbierdeman f2b6669
skip flow
nbierdeman 6b66e43
remove condition
nbierdeman a844c08
fix flow
wsbrunson 7080daa
break up tasks in main.yml
wsbrunson 160303a
fix yml
wsbrunson 1925cb3
remove matrix
wsbrunson e27fccf
whoops lol
wsbrunson dfc3664
run screenshot tests in separate action
nbierdeman 33420a2
try running a single screenshot test in ci
nbierdeman faf0400
double timeout time
nbierdeman 78c698d
nah, doubling the jest timeout didn't work
nbierdeman 610defa
add setupBrowserPage log
nbierdeman ef2fc17
use async/await in beforeAll
nbierdeman e9ddb37
remove beforeAll
nbierdeman b9a5e8a
add beforeAll
nbierdeman fcef504
remove iffy IIFE
nbierdeman 15d0d89
add iffy IIFE back in
nbierdeman cfa5d14
more setupBrowserPage logs
nbierdeman 251cd35
more logs
nbierdeman c210e13
more logs
nbierdeman 0c2787c
remove setupBrowserPage for...of loop
nbierdeman 3e252df
remove setupBrowserPage page.evaluate()
nbierdeman b01af7d
remove async/await from beforeAll
nbierdeman 5f30830
revert beforeAll to original state
nbierdeman c3490a9
revert screenshot tests to original state
nbierdeman e92be05
skip screenshot tests in ci
nbierdeman 3b65e28
remove config
nbierdeman 24559a5
add more scripts to test script
nbierdeman 802c81c
add husky
nbierdeman 20a9cbe
example comment
nbierdeman b915736
add husky pre-push
nbierdeman 6a3fbee
remove husky object
nbierdeman 53af196
remove test comment
nbierdeman 0ce5bd6
run screenshot tests in pre-push hook
nbierdeman 3944af6
skip pre-push hook in ci
nbierdeman eb9abd9
use exit code from npm run buttondiff
nbierdeman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
# Check if not running in GitHub Actions | ||
if [ -z "$CI" ]; then | ||
echo "Running pre-push hook in local environment" | ||
npm run buttondiff | ||
exit 0 | ||
else | ||
echo "Skipping pre-push hook in CI environment" | ||
exit 0 | ||
fi | ||
nbierdeman marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.