Feature/disable max height new fix #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikrom17
reviewed
Apr 9, 2025
…e and renamed responsive-test to styleUtils-test. Created new function getResponsiveStyleVariablesDisableMaxHeight.
…turn new sizes for BUTTON_DISABLE_HEIGHT_SIZE. CSS for disableMaxHeight added to end and returned in buttonResponsiveStyle()
…nts for button sizes medium/large-small/big. Refactored getResponsiveVariables and added disable max height logic to new function, getDisableMaxHeightResponsiveVariables
…sive.js by creating a new function to generate the disableMaxHeight styles
…nd the menu button. New functions created in styleUtils to calculate the css properties for these cases according to break points
delbarrow
force-pushed
the
feature/disableMaxHeight-new-fix
branch
from
4f0f0cc to
b7f575b
Compare
nikrom17
reviewed
Apr 11, 2025
…ZE/STYLE and added shouldResizeLabel test cases for getResponsiveVariables
We need to think about this edge cause when we do the full redesign. The min width of |
nikrom17
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature adds new css responsive styling based on the height of the button when disable max height is true.
The current responsive behavior of disableMaxHeight is not ideal since the height of the logo and label are based off the width of the button instead of the height.
To achieve this a new function, generateDisableMaxHeightStyles, was created which generates the new styling for disable max height based on height breakpoints set in, BUTTON_DISABLE_MAX_HEIGHT_STYLE. This new styling is appended below the previous styling.
[https://paypal.atlassian.net/browse/DTPPCPSDK-2986]
Before:
After:
Edge Cases to consider:
Specific styling for ApplePay, EPS, and MyBank