-
Notifications
You must be signed in to change notification settings - Fork 581
Feature/disable max height new fix #2485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a34bccf
Initial changes for disable max height fix, added a styleUtils.js fil…
delbarrow 1778c32
Updated getResponsiveStyleVariables to handle disableMaxHeight and re…
delbarrow 03b49d6
Updated code to fix flow errors
delbarrow 0898115
Added tests for disable max height responsiveness. Added new breakpoi…
delbarrow 54213bc
Added disableMaxHeight tests for rebrand button and refactored respon…
delbarrow f0ca07c
Fixed eslint errors
delbarrow b7f575b
Updated code to account for edge cases with APM buttons, Apple Pay, a…
delbarrow 42ee723
dist/ files restored and variable name updated in config.js
delbarrow 749dc91
Updated disable max height button size configurations
delbarrow 765f757
Updated test cases with new style variables and added test case to te…
delbarrow b3220de
restoring dist/button files to main
delbarrow 49e9c4e
Updated variable names to include MAX in BUTTON_DISABLE_MAX_HEIGHT_SI…
delbarrow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.