fix: various#129
Conversation
Only show the sparkles icon and personality name when isBrandUser is true, preventing logged-out users from seeing brand-specific UI elements. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously, clicking "Add logo" as a logged out user would show a dropdown menu with "Apply brand logo" and "Upload new" options. This should only appear for brand users who have an uploaded brand logo that's not currently applied. Now logged out users see the file picker directly when clicking "Add logo", which is the expected behavior. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 4ef1a7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request documents and implements UI fixes for logged-out users by restricting brand-specific interface elements to brand users only. Two changeset files record patch-level fixes: preventing the logo button from showing a dropdown menu for logged-out users and hiding the brand personality indicator in the font selector. The code changes add conditional logic based on Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 15
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| brandFontStyle={personalityStyle?.fontStyle} | ||
| brandPersonalityName={personalityName} | ||
| brandFontStyle={isBrandUser ? personalityStyle?.fontStyle : undefined} | ||
| brandPersonalityName={isBrandUser ? personalityName : undefined} |
There was a problem hiding this comment.
Brand user check applied at wrong abstraction layer
Low Severity
The isBrandUser check is applied at the call site to gate brandFontStyle and brandPersonalityName, but isBrandUser is also passed as a prop to FontStyleSelector. The component already uses isBrandUser for availableStyles but doesn't use it for brand indicator logic (isShowingBrandFont and isBrandDefault). The fix belongs inside FontStyleSelector where isBrandUser is already available, rather than requiring callers to remember to gate these props.
1 participant
Note
Low Risk
Small UI gating changes that only affect conditional rendering for logged-out vs brand users; low risk aside from potentially hiding/showing the wrong controls in edge cases.
Overview
Fixes logged-out UI behavior by making the logo upload control show the brand-logo dropdown only for
isBrandUsersessions, otherwise keeping a direct file picker.Also hides brand personality indicators in
FontStyleSelectorfor non-brand users by only passingbrandFontStyle/brandPersonalityNamewhenisBrandUseris true. Includes patch changesets documenting both fixes.Written by Cursor Bugbot for commit 4ef1a7b. Configure here.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.