Skip to content

fix: various #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peelar merged 2 commits into from
Jan 30, 2026
Merged

fix: various #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e6151
Hide brand personality indicator in font selector for logged out users
peelar Jan 29, 2026
4ef1a7b
Fix logo button showing dropdown for logged out users
peelar Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-logo-dropdown-logged-out.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"dopeshot-app": patch
---

Fix logo button showing dropdown menu for logged out users instead of direct file picker
5 changes: 5 additions & 0 deletions .changeset/hide-personality-logged-out.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"dopeshot-app": patch
---

Hide brand personality indicator in font selector for logged out users
6 changes: 3 additions & 3 deletions apps/app/src/components/config/layout-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ export const LayoutConfigPanel = ({

// Check if brand logo is currently applied
const isBrandLogoApplied = logoAsset && brandLogoAsset && logoAsset.id === brandLogoAsset.id;
// Check if brand logo is available but not applied
const hasBrandLogoAvailable = !logoAsset && brandSettings.logoUrl;

// Check if brand logo is available but not applied (only for brand users)
const hasBrandLogoAvailable = isBrandUser && !logoAsset && brandSettings.logoUrl;

// Check if text is actually supported (not just hidden by layout type)
const isPeakLeftOrRight = config.layoutId === "popup-gradient-left" || config.layoutId === "popup-gradient-right";
Expand Down
4 changes: 2 additions & 2 deletions apps/app/src/components/sidebar/layout-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ export function LayoutSection({ isBrandUser = false }: LayoutSectionProps) {
fontStyle={config.fontStyle}
onFontStyleChange={handleFontStyleChange}
isBrandUser={isBrandUser}
brandFontStyle={personalityStyle?.fontStyle}
brandPersonalityName={personalityName}
brandFontStyle={isBrandUser ? personalityStyle?.fontStyle : undefined}
brandPersonalityName={isBrandUser ? personalityName : undefined}

@cursor cursor Bot Jan 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brand user check applied at wrong abstraction layer

Low Severity

The isBrandUser check is applied at the call site to gate brandFontStyle and brandPersonalityName, but isBrandUser is also passed as a prop to FontStyleSelector. The component already uses isBrandUser for availableStyles but doesn't use it for brand indicator logic (isShowingBrandFont and isBrandDefault). The fix belongs inside FontStyleSelector where isBrandUser is already available, rather than requiring callers to remember to gate these props.

Fix in Cursor Fix in Web

/>
</div>
)}
Expand Down