Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable antialiasing option for move tool #1905

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

khoidauminh
Copy link
Contributor

Gives an option for the artist to transform without smoothing. Useful for pixel art.

@MrStevns MrStevns self-assigned this Apr 1, 2025
Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi khoidauminh

Thanks for contributing and sorry for the slow review time.

The PR looks good to me.

It's a bit annoying that we can't see the drawing being affected by the anti-aliasing flag in real time but that's not your fault. It comes down to the way the transformed selection is painted on the canvas which right now requires more involving changes to fix properly.

I have a PR in the works to address that specifically as well as some other concerns regarding the move and selection logic, so for now we'll accept this as a known issue that will be addressed in the future.

@MrStevns MrStevns merged commit b72a672 into pencil2d:master Apr 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants