Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable antialiasing option for move tool #1905

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Enable antialiasing option for move tool #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core_lib/src/interface/scribblearea.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,6 +1346,9 @@ void ScribbleArea::applyTransformedSelection()
mCanvasPainter.ignoreTransformedSelection();

Layer* layer = mEditor->layers()->currentLayer();

bool useAA = mEditor->tools()->currentTool()->properties.useAA;

if (layer == nullptr) { return; }

auto selectMan = mEditor->select();
Expand All @@ -1358,7 +1361,7 @@ void ScribbleArea::applyTransformedSelection()
handleDrawingOnEmptyFrame();
BitmapImage* bitmapImage = currentBitmapImage(layer);
if (bitmapImage == nullptr) { return; }
BitmapImage transformedImage = bitmapImage->transformed(selectMan->mySelectionRect().toRect(), selectMan->selectionTransform(), true);
BitmapImage transformedImage = bitmapImage->transformed(selectMan->mySelectionRect().toRect(), selectMan->selectionTransform(), useAA);


bitmapImage->clear(selectMan->mySelectionRect());
Expand Down
11 changes: 9 additions & 2 deletions core_lib/src/tool/movetool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,17 @@ ToolType MoveTool::type()

void MoveTool::loadSettings()
{
QSettings settings(PENCIL2D, PENCIL2D);

properties.width = -1;
properties.feather = -1;
properties.useFeather = false;
properties.stabilizerLevel = -1;
properties.useAA = -1;
properties.useAA = settings.value("moveAA").toBool();
mRotationIncrement = mEditor->preference()->getInt(SETTING::ROTATION_INCREMENT);
QSettings settings(PENCIL2D, PENCIL2D);
properties.showSelectionInfo = settings.value("ShowSelectionInfo").toBool();
mPropertyEnabled[SHOWSELECTIONINFO] = true;
mPropertyEnabled[ANTI_ALIASING] = true;

connect(mEditor->preference(), &PreferenceManager::optionChanged, this, &MoveTool::updateSettings);
}
Expand All @@ -64,6 +66,7 @@ void MoveTool::saveSettings()
QSettings settings(PENCIL2D, PENCIL2D);

settings.setValue("ShowSelectionInfo", properties.showSelectionInfo);
settings.setValue("moveAA", properties.useAA);

settings.sync();
}
Expand Down Expand Up @@ -338,6 +341,9 @@ bool MoveTool::leavingThisTool()
{
applyTransformation();
}

saveSettings();

return true;
}

Expand All @@ -349,6 +355,7 @@ bool MoveTool::isActive() const {
void MoveTool::resetToDefault()
{
setShowSelectionInfo(false);
setAA(true);
}

void MoveTool::setShowSelectionInfo(const bool b)
Expand Down
Loading