Add docker compose profile for emulating production #329
Conversation
There was a problem hiding this comment.
Overall, a very good starting point! Added @ryantanen and @dkwncho, as well as @danielxue for posterity.
When adding new configs, it's good to specify a reason for that. Especially when changing the docker-compose.yaml, it's good to add in-line code comments on why this is needed. Same thing for top of nginx-proddev.conf.
Also not the biggest fan of the name proddev: if you can think of a better one would be cool
| @@ -0,0 +1,17 @@ | |||
| from officehoursqueue.settings.production import * | |||
There was a problem hiding this comment.
Whats the reason for adding this new proddev.py
There was a problem hiding this comment.
It's a basis for the django settings for proddev. It is based off of the production settings, but with some changes so it still actually works in the development environment. For example, unless ALLOWED_HOSTS is changed, it will return a 400 error on every request.
There was a problem hiding this comment.
I don't believe it's possible to override Django settings with just environment variables without changing settings files.
joyliu-q
left a comment
joyliu-q
left a comment
There was a problem hiding this comment.
Theoretically lgtm. Would feel good about merging it as long as you tested it.
* Migrate dev environment to uv * Migrate docker setup to uv * Move instead of copy uv-installed binaries * Move .dockerignore .venv from uv section to misc * Revert default dependency manager back to pipenv for docker images * Install uv in a simpler way in docker * Merge project dependency copy in backend docker * Simplify pipenv or uv install in docker
joyliu-q
left a comment
joyliu-q
left a comment
There was a problem hiding this comment.
Shaping up quite nicely! A small comment (feel free to ping me once u addressed) and should be good to go!
Most important aspect of this is that it tests
django-runandasgi-runare working. Not intended to replace development or production environment.