Skip to content

Conversation

@dleadbetter
Copy link
Contributor

This pull request fixes an issue with the ViafIdentifierForm using an outdated payload structure. It also fixes a CSS issue with the width of the search input element.

This pull request will remain a draft until a new release of core_data_connector is published.

@dleadbetter dleadbetter added the v1.1.4 Issues in v1.1.4 label Sep 19, 2025
@dleadbetter dleadbetter requested a review from blms September 19, 2025 12:46
Comment on lines +16 to +22
const PATH = [
'ns1:VIAFCluster',
'ns1:mainHeadings',
'ns1:data'
];

const NAME_ATTRIBUTE = 'ns1:text';
Copy link
Contributor

@blms blms Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ns1 for every result in the response? I actually had to configure a Python VIAF API library to use the new API response and I found that it increased ns2, ns3 etc per each subsequent result. Though not 100% sure we're using the same endpoint (this one was for /search I believe). And since we're only doing this after selecting an entry maybe we only want the first result?

Just in case, here are all the changes I had to make in that library:

API reference

  • Changes to the search params and headers:

    • maximumRecords can only be a maximum of 10 (documented)
    • sortKeys has been renamed to sortKey, and only accepts holdingscount (documented)
    • httpAccept/Accept params no longer work, but passing an Accept header does (not documented)
  • Changes to search results (none documented):

    • Search results are now nested as records: { record: [] } or records: { record: {} }
    • Metadata is now nested under VIAFCluster inside of recordData
    • Most JSON keys are now "namespaced" using ns2:, ns3:, ns4: prefixes, which increase per result. For example, a result's recordData might look like
      {"ns2:VIAFCluster": {"ns2:mainHeadings": {"ns2:data": {"ns2:text": "My Name"}}}}
      and the following search result will have the same keys but with ns3: prefixed, etc. up to ns11.
    • Other small things, like numberOfRecords count being nested under content now, and @about renamed to about

@blms blms changed the title CDC #501 - Identifiers CDC #464 - VIAF Identifiers Sep 23, 2025
@blms blms added v1.1.5 Issues in v1.1.5 and removed v1.1.4 Issues in v1.1.4 labels Sep 23, 2025
@blms blms added v1.1.6 Issues in v1.1.6 and removed v1.1.5 Issues in v1.1.5 labels Oct 13, 2025
@ajolipa ajolipa added v1.1.7 Issues in v1.1.7 v1.1.8 Issues in v1.1.8 and removed v1.1.6 Issues in v1.1.6 v1.1.7 Issues in v1.1.7 labels Oct 14, 2025
@dleadbetter dleadbetter added v1.1.9 Issues in v1.1.9 and removed v1.1.8 Issues in v1.1.8 labels Nov 5, 2025
@dleadbetter dleadbetter added next release Issues in the next release and removed v1.1.9 Issues in v1.1.9 labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next release Issues in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants