-
Notifications
You must be signed in to change notification settings - Fork 1
CDC #464 - VIAF Identifiers #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| const PATH = [ | ||
| 'ns1:VIAFCluster', | ||
| 'ns1:mainHeadings', | ||
| 'ns1:data' | ||
| ]; | ||
|
|
||
| const NAME_ATTRIBUTE = 'ns1:text'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ns1 for every result in the response? I actually had to configure a Python VIAF API library to use the new API response and I found that it increased ns2, ns3 etc per each subsequent result. Though not 100% sure we're using the same endpoint (this one was for /search I believe). And since we're only doing this after selecting an entry maybe we only want the first result?
Just in case, here are all the changes I had to make in that library:
Changes to the search params and headers:
maximumRecordscan only be a maximum of 10 (documented)sortKeyshas been renamed tosortKey, and only acceptsholdingscount(documented)httpAccept/Acceptparams no longer work, but passing anAcceptheader does (not documented)Changes to search results (none documented):
- Search results are now nested as
records: { record: [] }orrecords: { record: {} }- Metadata is now nested under
VIAFClusterinside ofrecordData- Most JSON keys are now "namespaced" using
ns2:,ns3:,ns4:prefixes, which increase per result. For example, a result'srecordDatamight look likeand the following search result will have the same keys but with{"ns2:VIAFCluster": {"ns2:mainHeadings": {"ns2:data": {"ns2:text": "My Name"}}}}ns3:prefixed, etc. up tons11.- Other small things, like
numberOfRecordscount being nested undercontentnow, and@aboutrenamed toabout
This pull request fixes an issue with the
ViafIdentifierFormusing an outdated payload structure. It also fixes a CSS issue with the width of the search input element.This pull request will remain a draft until a new release of
core_data_connectoris published.