Update to faircopy_cloud_url constructor for FCC2 compatibility
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleadbetter
approved these changes
Sep 2, 2025
Contributor
Do we want to do this programmatically via a migration? Or is the number of projects using this so limited it's easier to do manually? |
Contributor
Author
My belief is that the number of projects using it is small enough that we should just update manually. Just looking at how many projects (on staging or prod) have the |
camdendotlol
added
v0.1.103
dleadbetter
added
v0.1.108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
This PR updates how the
faircopy_cloud_urlfrom which FairData fetches the CSVs created by FCC is constructed to allow more flexibility. This should allow for backwards compatibility with minimal disruption; existing projects will need to add/documentsto the end of the configured FairCopy Cloud URL in the project settings, but no other changes should be needed. For new projects on FCC2, the FCC URL set in the project settings should behttps://beta-api.faircopy.cloud/<projectID>/tei_documents. (Or whatever the appropriate host name is.)