feat(search): scope memory search by workspace - #196
Closed
yordis wants to merge 3 commits into
Closed
Conversation
yordis
force-pushed
the
yordis/filter-by-workspace
branch
from
June 28, 2026 01:52
62215b4 to
e58fbd1
Compare
Memories can be owned by either a workspace or a project, but search only exposed project-level scoping; agents working at the workspace level had no way to query "everything in this workspace" in a single call. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/filter-by-workspace
branch
from
June 28, 2026 01:53
e58fbd1 to
c85f4ec
Compare
yordis
marked this pull request as ready for review
June 28, 2026 01:56
Member
|
I patched the review findings on branch Fixes included:
Verification:
I could not push directly to the PR head fork |
Contributor
Author
|
@Aaronontheweb I put your changes in it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search_memories, RESTGET /api/memory/search, and the underlyingHybridSearch/SearchWithMetadataEmbedding) only exposed project-level scoping, leaving no way to query "everything in this workspace" in a single call.projectIdandworkspaceIdare kept mutually exclusive so the API stays unambiguous and easy to evolve — adding union/intersect semantics later is reversible; reserving the namespace now is not.