Skip to content

feat(search): scope memory search by workspace #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yordis wants to merge 3 commits into from
Closed

feat(search): scope memory search by workspace #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c85f4ec
feat(search): scope memory search by workspace
yordis Jun 28, 2026
751d9bd
fix(search): close workspace scoping gaps
Aaronontheweb Jul 1, 2026
5277da3
fix(tools): allow storing memories in workspaces
Aaronontheweb Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 153 additions & 0 deletions src/Memorizer.IntegrationTests/McpToolsProjectScopingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,4 +451,157 @@ public async Task MoveMemoryToUnfiled_MovesBackToUnfiled()
}

#endregion

#region Workspace-Scoped Search Tests

[Fact]
public async Task SearchWithMetadataEmbedding_WithWorkspaceId_RollsUpWorkspaceAndProjects()
{
var storage = _services.GetRequiredService<IStorage>();

var workspaceA = await storage.CreateWorkspaceAsync("Workspace A", null, cancellationToken: default);
var workspaceB = await storage.CreateWorkspaceAsync("Workspace B", null, cancellationToken: default);
var projectA1 = await storage.CreateProjectAsync(workspaceA.Id, "Project A1", null, cancellationToken: default);
var projectA2 = await storage.CreateProjectAsync(workspaceA.Id, "Project A2", null, cancellationToken: default);
var projectB1 = await storage.CreateProjectAsync(workspaceB.Id, "Project B1", null, cancellationToken: default);

Memory? memoryOnWorkspaceA = null;
Memory? memoryInProjectA1 = null;
Memory? memoryInProjectA2 = null;
Memory? memoryOnWorkspaceB = null;
Memory? memoryInProjectB1 = null;

try
{
memoryOnWorkspaceA = await storage.StoreMemory(
type: "reference",
content: "Workspace A shared note about flux capacitor configuration",
source: "test",
tags: null,
confidence: new Confidence(1.0),
title: "Workspace A Note",
owner: MemoryOwner.ForWorkspace(workspaceA.Id),
cancellationToken: default
);

memoryInProjectA1 = await storage.StoreMemory(
type: "reference",
content: "Project A1 details about flux capacitor configuration",
source: "test",
tags: null,
confidence: new Confidence(1.0),
title: "Project A1 Note",
owner: MemoryOwner.ForProject(projectA1.Id),
cancellationToken: default
);

memoryInProjectA2 = await storage.StoreMemory(
type: "reference",
content: "Project A2 details about flux capacitor configuration",
source: "test",
tags: null,
confidence: new Confidence(1.0),
title: "Project A2 Note",
owner: MemoryOwner.ForProject(projectA2.Id),
cancellationToken: default
);

memoryOnWorkspaceB = await storage.StoreMemory(
type: "reference",
content: "Workspace B unrelated note about flux capacitor configuration",
source: "test",
tags: null,
confidence: new Confidence(1.0),
title: "Workspace B Note",
owner: MemoryOwner.ForWorkspace(workspaceB.Id),
cancellationToken: default
);

memoryInProjectB1 = await storage.StoreMemory(
type: "reference",
content: "Project B1 unrelated note about flux capacitor configuration",
source: "test",
tags: null,
confidence: new Confidence(1.0),
title: "Project B1 Note",
owner: MemoryOwner.ForProject(projectB1.Id),
cancellationToken: default
);

var results = await storage.SearchWithMetadataEmbedding(
query: "flux capacitor configuration",
limit: 20,
minSimilarity: new SimilarityScore(0.0),
filterTags: null,
projectId: null,
includeUnassigned: false,
includeArchived: false,
includeSystem: false,
workspaceId: workspaceA.Id,
cancellationToken: default
);

var resultIds = results.Select(m => m.Id).ToHashSet();

Assert.Contains(memoryOnWorkspaceA.Id, resultIds);
Assert.Contains(memoryInProjectA1.Id, resultIds);
Assert.Contains(memoryInProjectA2.Id, resultIds);
Assert.DoesNotContain(memoryOnWorkspaceB.Id, resultIds);
Assert.DoesNotContain(memoryInProjectB1.Id, resultIds);
}
finally
{
if (memoryOnWorkspaceA != null) await storage.Delete(memoryOnWorkspaceA.Id, default);
if (memoryInProjectA1 != null) await storage.Delete(memoryInProjectA1.Id, default);
if (memoryInProjectA2 != null) await storage.Delete(memoryInProjectA2.Id, default);
if (memoryOnWorkspaceB != null) await storage.Delete(memoryOnWorkspaceB.Id, default);
if (memoryInProjectB1 != null) await storage.Delete(memoryInProjectB1.Id, default);

await storage.DeleteProjectAsync(projectA1.Id, default);
await storage.DeleteProjectAsync(projectA2.Id, default);
await storage.DeleteProjectAsync(projectB1.Id, default);
await storage.DeleteWorkspaceAsync(workspaceA.Id, default);
await storage.DeleteWorkspaceAsync(workspaceB.Id, default);
}
}

[Fact]
public async Task SearchWithMetadataEmbedding_WithBothProjectIdAndWorkspaceId_Throws()
{
var storage = _services.GetRequiredService<IStorage>();

await Assert.ThrowsAsync<ArgumentException>(() => storage.SearchWithMetadataEmbedding(
query: "anything",
limit: 5,
minSimilarity: new SimilarityScore(0.5),
filterTags: null,
projectId: ProjectId.New(),
includeUnassigned: false,
includeArchived: false,
includeSystem: false,
workspaceId: WorkspaceId.New(),
cancellationToken: default
));
}

[Fact]
public async Task HybridSearch_WithBothProjectIdAndWorkspaceId_Throws()
{
var storage = _services.GetRequiredService<IStorage>();

await Assert.ThrowsAsync<ArgumentException>(() => storage.HybridSearch(
query: "anything",
limit: 5,
minSimilarity: new SimilarityScore(0.5),
filterTags: null,
projectId: ProjectId.New(),
includeUnassigned: false,
includeArchived: false,
includeSystem: false,
workspaceId: WorkspaceId.New(),
cancellationToken: default
));
}

#endregion
}
4 changes: 2 additions & 2 deletions src/Memorizer.IntegrationTests/TitleGenerationActorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,13 +210,13 @@ public Task UpdateMemoryEmbeddings(MemoryId memoryId, Vector contentEmbedding, V
public Task<List<Memory>> SearchWithFullEmbedding(string query, int limit = 10, SimilarityScore? minSimilarity = null, string[]? filterTags = null, bool includeArchived = false, CancellationToken cancellationToken = default)
=> throw new NotImplementedException("Test mock");

public Task<List<Memory>> SearchWithMetadataEmbedding(string query, int limit = 10, SimilarityScore? minSimilarity = null, string[]? filterTags = null, ProjectId? projectId = null, bool includeUnassigned = false, bool includeArchived = false, bool includeSystem = false, CancellationToken cancellationToken = default)
public Task<List<Memory>> SearchWithMetadataEmbedding(string query, int limit = 10, SimilarityScore? minSimilarity = null, string[]? filterTags = null, ProjectId? projectId = null, bool includeUnassigned = false, bool includeArchived = false, bool includeSystem = false, WorkspaceId? workspaceId = null, CancellationToken cancellationToken = default)
=> throw new NotImplementedException("Test mock");

public Task<(List<Memory> FullResults, List<Memory> MetadataResults)> CompareSearchMethods(string query, int limit = 10, SimilarityScore? minSimilarity = null, string[]? filterTags = null, CancellationToken cancellationToken = default)
=> throw new NotImplementedException("Test mock");

public Task<List<Memory>> HybridSearch(string query, int limit = 10, SimilarityScore? minSimilarity = null, string[]? filterTags = null, ProjectId? projectId = null, bool includeUnassigned = false, bool includeArchived = false, bool includeSystem = false, CancellationToken cancellationToken = default)
public Task<List<Memory>> HybridSearch(string query, int limit = 10, SimilarityScore? minSimilarity = null, string[]? filterTags = null, ProjectId? projectId = null, bool includeUnassigned = false, bool includeArchived = false, bool includeSystem = false, WorkspaceId? workspaceId = null, CancellationToken cancellationToken = default)
=> throw new NotImplementedException("Test mock");

// Versioning support
Expand Down
Loading