Fix live code examples in Firefox-based browsers#1409
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1408.
The docs live-code preview iframe now mounts through a browser-agnostic iframe document path instead of depending on a Firefox-specific load/ref branch. The preview iframe also gets an explicit empty document and a full-height document root so examples that use
height: '100%'can measure correctly in Firefox-based browsers like Zen.Validation
pnpm exec oxfmt --check apps/virtuoso.dev/src/components/LiveCodeBlock/LiveCodeBlock.tsx apps/virtuoso.dev/src/components/LiveCodeBlock/iframe-style.cssNote: the pre-commit lint hook is currently blocked by the existing oxlint config error
Rule 'prop-types' not found in plugin 'react', so the commit was created with hooks skipped after the scoped formatter check passed.