Skip to content

Fix live code examples in Firefox-based browsers#1409

Merged
petyosi merged 1 commit into
mainfrom
petyosi/fix-zen-live-examples
May 18, 2026
Merged

Fix live code examples in Firefox-based browsers#1409
petyosi merged 1 commit into
mainfrom
petyosi/fix-zen-live-examples

Conversation

@petyosi

@petyosi petyosi commented May 18, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes #1408.

The docs live-code preview iframe now mounts through a browser-agnostic iframe document path instead of depending on a Firefox-specific load/ref branch. The preview iframe also gets an explicit empty document and a full-height document root so examples that use height: '100%' can measure correctly in Firefox-based browsers like Zen.

Validation

  • User verified the live examples work in Zen.
  • pnpm exec oxfmt --check apps/virtuoso.dev/src/components/LiveCodeBlock/LiveCodeBlock.tsx apps/virtuoso.dev/src/components/LiveCodeBlock/iframe-style.css

Note: the pre-commit lint hook is currently blocked by the existing oxlint config error Rule 'prop-types' not found in plugin 'react', so the commit was created with hooks skipped after the scoped formatter check passed.

@changeset-bot

changeset-bot Bot commented May 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a4b984a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petyosi petyosi merged commit 921446b into main May 18, 2026
6 checks passed
@petyosi petyosi deleted the petyosi/fix-zen-live-examples branch May 18, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Examples doesn't work on Firefox (Zen)

1 participant