Skip to content

Fix live code examples in Firefox-based browsers #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petyosi merged 1 commit into from
May 18, 2026
+29 −18
Merged

Fix live code examples in Firefox-based browsers #1409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions apps/virtuoso.dev/src/components/LiveCodeBlock/LiveCodeBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ function configureMonacoWorkers() {
}
}

const isFirefox = typeof navigator !== 'undefined' && navigator.userAgent.toLowerCase().includes('firefox')

function getCodeTypographyFromCSS(): {
fontFamily: string
fontSize: number
Expand Down Expand Up @@ -95,32 +93,40 @@ const iframeThemeStyles = {
`,
}

const iframeSource = '<!doctype html><html><head></head><body></body></html>'

const IframePortal: React.FC<{ children: React.ReactNode; theme: Theme }> = ({ children, theme }) => {
const [iFrameEl, setIframeEl] = React.useState<HTMLIFrameElement | null>(null)
const [portalRoot, setPortalRoot] = React.useState<HTMLElement | null>(null)

useEffect(() => {
if (!iFrameEl) {
setPortalRoot(null)
return
}

const updatePortalRoot = () => {
setPortalRoot(iFrameEl.contentDocument?.body ?? null)
}

updatePortalRoot()
iFrameEl.addEventListener('load', updatePortalRoot)

return () => {
iFrameEl.removeEventListener('load', updatePortalRoot)
}
}, [iFrameEl])

return (
<iframe
onLoad={(e) => {
if (isFirefox) {
// oxlint-disable-next-line typescript-eslint(no-unsafe-type-assertion)
setIframeEl(e.target as HTMLIFrameElement)
}
}}
ref={(el) => {
if (!isFirefox) {
setIframeEl(el)
}
}}
style={{ height: '100%', width: '100%' }}
>
{iFrameEl?.contentDocument
<iframe ref={setIframeEl} srcDoc={iframeSource} style={{ height: '100%', width: '100%' }} title="Live code preview">
{portalRoot
? createPortal(
<>
<style>{iFrameStyle}</style>
<style>{iframeThemeStyles[theme]}</style>
{children}
</>,
iFrameEl.contentDocument.body
portalRoot
)
: null}
</iframe>
Expand Down
5 changes: 5 additions & 0 deletions apps/virtuoso.dev/src/components/LiveCodeBlock/iframe-style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
margin: 0;
}

html,
body {
height: 100%;
}

body {
line-height: 1.5;
-webkit-font-smoothing: antialiased;
Expand Down
Loading