Conversation
…ure-branch Add verification harness for neuroplasticity gold corpus
…with-fixes Add index directory support to multi-agent RAG tooling
…tion-check Fix GPU dependency detection in CI
…nd-improve-cli Fix multi-agent invocation in verification harness
fix(lc_ask): require key-derived faiss selection
* Dev (#206) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * Dev (#207) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| if (cand / "index.faiss").exists(): | ||
| faiss_dir = cand | ||
| break | ||
|
|
||
| if args.index_path: | ||
| if args.index_path: |
There was a problem hiding this comment.
[P0] Fix indentation in lc_ask main()
The new branch that handles --index vs --key is mis-indented. The line starting with if args.index_path: is dedented with three spaces relative to the four-space block above, so importing or running src/langchain/lc_ask.py now raises IndentationError: unindent does not match any outer indentation level before the CLI can even parse arguments. Try python -m py_compile src/langchain/lc_ask.py or python src/langchain/lc_ask.py to see the failure. The CLI is therefore unusable until the indentation is corrected.
Useful? React with 👍 / 👎.
* Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * mege (#208) * Dev (#206) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * Dev (#207) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection
1 participant
No description provided.