-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Dev #207
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a9ef35f
Fix verification harness index build commands
pfahlr 352338c
Merge pull request #191 from pfahlr/codex/redo-code-changes-from-feat…
pfahlr fb28fff
Add index directory support to multi-agent RAG tooling
pfahlr 5de86a7
Merge pull request #192 from pfahlr/codex/recreate-pull-request-#181-…
pfahlr cd6dcad
Fix GPU dependency detection in CI
pfahlr ff9626d
Merge pull request #193 from pfahlr/codex/fix-gpu-dependency-installa…
pfahlr e07af07
Fix multi-agent invocation in verification harness
pfahlr 5c8ae61
Merge pull request #194 from pfahlr/codex/fix-index-build-arguments-a…
pfahlr d31fe32
fix(lc_ask): require key-derived faiss selection
pfahlr 0fb8559
Merge pull request #195 from pfahlr/codex/add-cli-option-for-index-dir
pfahlr 2131c8d
Merge branch 'main' into dev
pfahlr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Fix indentation in lc_ask main()
The new branch that handles
--indexvs--keyis mis-indented. The line starting withif args.index_path:is dedented with three spaces relative to the four-space block above, so importing or runningsrc/langchain/lc_ask.pynow raisesIndentationError: unindent does not match any outer indentation levelbefore the CLI can even parse arguments. Trypython -m py_compile src/langchain/lc_ask.pyorpython src/langchain/lc_ask.pyto see the failure. The CLI is therefore unusable until the indentation is corrected.Useful? React with 👍 / 👎.