Conversation
…ure-branch Add verification harness for neuroplasticity gold corpus
…with-fixes Add index directory support to multi-agent RAG tooling
…tion-check Fix GPU dependency detection in CI
…nd-improve-cli Fix multi-agent invocation in verification harness
fix(lc_ask): require key-derived faiss selection
* Dev (#206) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection * Dev (#207) * Fix verification harness index build commands * Add index directory support to multi-agent RAG tooling * Fix GPU dependency detection in CI * Fix multi-agent invocation in verification harness * fix(lc_ask): require key-derived faiss selection
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| # Prefer a repacked/merged index if available | ||
|
|
||
| faiss_dir: Path | None = None | ||
| expected_chunks: Path | None = None | ||
|
|
||
| for cand in (repacked_dir, base_dir): | ||
| if (cand / "index.faiss").exists(): | ||
| faiss_dir = cand | ||
| break | ||
|
|
||
| if args.index_path: | ||
| if args.index_path: | ||
| faiss_dir = Path(args.index_path).expanduser() | ||
| if not faiss_dir.exists(): | ||
| raise SystemExit(f"[lc_ask] FAISS dir not found: {faiss_dir}") |
There was a problem hiding this comment.
[P0] Fix indentation in FAISS path resolution
The recent edits around _prepare_index_locations left the if args.index_path block with a smaller indent than the surrounding code. Importing src/langchain/lc_ask.py now raises IndentationError: unindent does not match any outer indentation level (line 357), which prevents the CLI from running at all.
Useful? React with 👍 / 👎.
| assert command[:2] == [sys.executable, str(builder)] | ||
|
|
||
| assert command[0] == sys.executable | ||
| assert command[1:3] == ["-m", "src.langchain.lc_build_index"] |
There was a problem hiding this comment.
[P1] Impossible assertion in builder command test
test_build_builder_command_targets_pdf_and_chunks asserts both command[:2] == [sys.executable, str(builder)] and command[1:3] == ["-m", "src.langchain.lc_build_index"]. These conditions cannot be simultaneously true because command[1] cannot be both str(builder) and "-m". As written the new test will always fail, regardless of the command produced by build_builder_command.
Useful? React with 👍 / 👎.
1 participant
No description provided.