-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #210
Changes from all commits
a9ef35f
352338c
fb28fff
5de86a7
cd6dcad
ff9626d
e07af07
5c8ae61
d31fe32
0fb8559
2131c8d
60cdcb1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,9 @@ def test_build_builder_command_targets_pdf_and_chunks(tmp_path: Path) -> None: | |
| index_dir=index_dir, | ||
| ) | ||
|
|
||
|
|
||
| assert command[:2] == [sys.executable, str(builder)] | ||
|
|
||
| assert command[0] == sys.executable | ||
| assert command[1:3] == ["-m", "src.langchain.lc_build_index"] | ||
|
Comment on lines
+54
to
57
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P1] Impossible assertion in builder command test
Useful? React with 👍 / 👎. |
||
| assert "--input-dir" in command | ||
|
|
@@ -81,6 +84,7 @@ def test_build_question_invocation_for_asker_uses_key_and_index(tmp_path: Path) | |
| ) | ||
|
|
||
| assert route == "asker" | ||
|
|
||
| assert command[0] == sys.executable | ||
| assert command[1:3] == ["-m", "src.langchain.lc_ask"] | ||
| assert "--key" in command | ||
|
|
@@ -115,6 +119,7 @@ def test_build_question_invocation_for_multi_agent_omits_legacy_subcommand( | |
| ) | ||
|
|
||
| assert route == "multi" | ||
|
|
||
| assert command[0] == sys.executable | ||
| assert command[1:3] == ["-m", "src.cli.multi_agent"] | ||
| assert "ask" not in command | ||
|
|
@@ -191,3 +196,4 @@ def main() -> None: | |
| flag = determine_flag(script, ["--index", "--index-dir"]) | ||
|
|
||
| assert flag == "--index-dir" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Fix indentation in FAISS path resolution
The recent edits around
_prepare_index_locationsleft theif args.index_pathblock with a smaller indent than the surrounding code. Importingsrc/langchain/lc_ask.pynow raisesIndentationError: unindent does not match any outer indentation level (line 357), which prevents the CLI from running at all.Useful? React with 👍 / 👎.