Fix assignment operator bug in DESC order partition data functions #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed incorrect use of comparison operator (=) instead of assignment operator (:=) in partition_data_time and partition_data_id functions when processing data in DESC order with batch intervals. This bug caused variable assignments to be treated as boolean comparisons that were evaluated and discarded, preventing proper calculation of partition boundaries when using p_order := 'DESC'. Affected locations: - partition_data_time.sql line 252: v_min_partition_timestamp assignment - partition_data_id.sql line 154: v_min_partition_id assignment (ASC) - partition_data_id.sql line 168: v_min_partition_id assignment (DESC) - partition_data_id.sql line 174: v_min_partition_id batch adjustment This resolves issue pgpartman#828 where partition_data_proc would fail with "relation does not exist" errors when called with p_order := 'DESC' and a p_interval parameter on monthly partitioned tables.
|
NOTE: PR generated by Claude Code based on the issue I'd written up here. Admittedly I'm not a PL/SQL expert so I'm not sure this is a valid fix, and I haven't build/tested this myself, but submitting it in the hopes it'll be useful to the maintainers. Btw I've loved my first experience with pg_partman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #828
Problem
The
partition_data_procfunction failed when called withp_order := 'DESC'and ap_intervalparameter, causing errors like:ERROR: relation "my_table_p20251105" does not exist
Root Cause
The code incorrectly used
=(comparison operator) instead of:=(assignment operator) in PL/pgSQL. This caused variable assignments to be evaluated as boolean comparisons and discarded, rather than actually updating thevariables.
Solution
Changed all affected instances of
=to:=for proper variable assignments in:partition_data_time.sqlline 252:v_min_partition_timestampassignment for DESC order with batch intervalspartition_data_id.sqllines 154, 168, 174:v_min_partition_idassignments for both ASC and DESC orderTesting
The fix ensures that when using DESC order, the partition boundary calculations correctly respect the partition interval (e.g., monthly) rather than defaulting to incorrect daily boundaries.