Skip to content

Fix assignment operator bug in DESC order partition data functions #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
+4 −4
Open

Fix assignment operator bug in DESC order partition data functions #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sql/functions/partition_data_id.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ FOR i IN 1..p_batch_count LOOP
IF v_start_control IS NULL THEN
EXIT;
END IF;
v_min_partition_id = v_start_control - (v_start_control % v_partition_interval);
v_min_partition_id := v_start_control - (v_start_control % v_partition_interval);
v_partition_id := ARRAY[v_min_partition_id];
-- Check if custom batch interval overflows current partition maximum
IF (v_start_control + p_batch_interval) >= (v_min_partition_id + v_partition_interval) THEN
Expand All @@ -165,13 +165,13 @@ FOR i IN 1..p_batch_count LOOP
IF v_start_control IS NULL THEN
EXIT;
END IF;
v_min_partition_id = v_start_control - (v_start_control % v_partition_interval);
v_min_partition_id := v_start_control - (v_start_control % v_partition_interval);
-- Must be greater than max value still in parent table since query below grabs < max
v_max_partition_id := v_min_partition_id + v_partition_interval;
v_partition_id := ARRAY[v_min_partition_id];
-- Make sure minimum doesn't underflow current partition minimum
IF (v_start_control - p_batch_interval) >= v_min_partition_id THEN
v_min_partition_id = v_start_control - p_batch_interval;
v_min_partition_id := v_start_control - p_batch_interval;
END IF;
ELSE
RAISE EXCEPTION 'Invalid value for p_order. Must be ASC or DESC';
Expand Down
2 changes: 1 addition & 1 deletion sql/functions/partition_data_time.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ FOR i IN 1..p_batch_count LOOP
v_max_partition_timestamp := v_min_partition_timestamp + v_partition_interval;
-- Ensure batch interval given as parameter doesn't cause minimum to underflow current partition minimum
IF (v_start_control - p_batch_interval) >= v_min_partition_timestamp THEN
v_min_partition_timestamp = v_start_control - p_batch_interval;
v_min_partition_timestamp := v_start_control - p_batch_interval;
END IF;
ELSE
RAISE EXCEPTION 'Invalid value for p_order. Must be ASC or DESC';
Expand Down