Conversation
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/785a5c13-5fb3-4669-845d-46eef810f017 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/785a5c13-5fb3-4669-845d-46eef810f017 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/785a5c13-5fb3-4669-845d-46eef810f017 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/785a5c13-5fb3-4669-845d-46eef810f017 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/785a5c13-5fb3-4669-845d-46eef810f017 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/785a5c13-5fb3-4669-845d-46eef810f017 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/785a5c13-5fb3-4669-845d-46eef810f017 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/785a5c13-5fb3-4669-845d-46eef810f017 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
|
I want to supply the tar.gz for comparions. The tool should be able to unpback these tar.gz and compare the files "package_version","root_path","relative_path","file_path","file_size_bytes" currently it looks like the tool is just comparing the total size of the package |
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/391d4a12-f329-4ef2-8be2-bc3d23c1b31d Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Implemented in commit The addin now accepts either directories or No UI changes were made in this update. |
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/8ce0f4dd-99d9-4979-a6e5-1e2190e6b4c2 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/8ce0f4dd-99d9-4979-a6e5-1e2190e6b4c2 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Implemented in commit The addin now handles the case where a directory is provided that contains a single No UI changes were made in this update. |
@bundfussr, @manciniedoardo @adcascone, @jeffreyad @millerg23 was messing around with this old pkg to maybe offer a way to quickly compare the package sizes. installed is 1.4.1 and dev is whatever is in main right now. looks promising - report is just two sad looking csv files, but we could spruce up if wanting |
|
just thinking as we are doing this - be really nice to have a way to quickly do the compare, get a report to look at and throw into PR for reducing size |
Thinking out loud here, but if this is likely to be a concern for the forseeable, then it could be an idea to have an action that creates this report for every PR, just so we keep on top of things. |
I am really hesitant on another action. maybe something to put in the checklist - to use the addin if you created a new vignette, new datasets, a lot of new files, etc? but maybe we could this working and get happy with the report first and then think on the action? |
|
Could we replace the |
Yes, agree |
|
@copilot can you also create a third csv file with the total size of the two packages being compared |
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/d9b1d746-9593-4119-a843-5a3ed98053b1 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/d9b1d746-9593-4119-a843-5a3ed98053b1 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/d9b1d746-9593-4119-a843-5a3ed98053b1 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Implemented in commit A third CSV is now generated: |
|
@copilot can you also provide a column for total MB in the total csv |
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/8c0359f9-4704-4211-a6ff-07bad9999f68 Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
Implemented in commit The totals CSV now includes |
|
package_version I feel like some of these calculations are off as I believe the current size of the development version of the package is 5 MB, but this says it is 6.43 |
Agent-Logs-Url: https://github.com/pharmaverse/pharmaverse4devs/sessions/fc4a1a9b-adb1-4548-a5c4-bb0fd3fe487f Co-authored-by: bms63 <10111024+bms63@users.noreply.github.com>
|
... Implemented in commit You’re right — this was a compressed-vs-unpacked interpretation issue for
The existing |




admiralis nearing CRAN package size limits, and repeatedly comparing dev vs installed package contents was manual and error-prone. This PR adds an addin workflow that generates consistent file-level size reports for both versions.New addin: package size comparison
run_compare_package_sizes()as an RStudio addin entry point.~).tar.gzfiles.tar.gz(and is not a package root), it is automatically resolved to that tarball for comparison.inst/rstudio/addins.dcfas Compare package sizes.Report generation
compare_package_sizes()to generate three CSV outputs in the user-selected directory:filenamedev_exists,installed_exists) for files present in only one version.input_type(tar.gzordirectory;differencefor diff row)input_size_bytesinput_size_kbinput_size_mbtotal_size_bytestotal_size_kbtotal_size_mbdiff_development_minus_installedrows..tar.gzinputs, archives are unpacked to temporary directories and compared by internal file paths (not archive file size only), with normalization to avoid versioned top-level folder mismatches.Package surface/docs updates
NAMESPACE.man/run_compare_package_sizes.Rd.