Skip to content

(Closes issue #131) Make cal_min_max_date (and by extension oak_cal_ref_dates) work with Date objects and hms time objects (not just character date and time strings)#135

Open
zhengzheli wants to merge 2 commits intopharmaverse:mainfrom
EffectStats:allow_calminmaxdate_to_handle_Date_and_time_objects
Open

(Closes issue #131) Make cal_min_max_date (and by extension oak_cal_ref_dates) work with Date objects and hms time objects (not just character date and time strings)#135
zhengzheli wants to merge 2 commits intopharmaverse:mainfrom
EffectStats:allow_calminmaxdate_to_handle_Date_and_time_objects

Conversation

@zhengzheli
Copy link
Copy Markdown

@zhengzheli zhengzheli commented Dec 8, 2025

#131
Create_iso8601 in cal_min_max_date expects a character string, but cal_min_max_date may refer to date variables and time variables that are not in a string format.
For example, the date may be a Date object, and the time may be an hms object, if the haven::read_sas() function was used to convert a sas dataset into an R dataframe.
So we make a small adjustment to allow for Date objects and hms time objects.

Thank you for your Pull Request! We have developed this task checklist from the
Development Process
Guide

to help with the final steps of the process. Completing the below tasks helps to
ensure our reviewers can maximize their time on your code as well as making sure
the oak codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task
or check off that it is not relevant to your Pull Request. This checklist is
part of the Github Action workflows and the Pull Request will not be merged into
the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull z
    Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the
    tidyverse style guide. Run
    styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should
    consider realistic data scenarios and edge cases, e.g. empty datasets, errors,
    boundary cases etc. - See
    Unit Test Guide
  • (Did not remove/place functions or parameters) If you removed/replaced any function and/or function parameters, did you
    fully follow the
    deprecation guidance?
  • (Did not create any functions) Update to all relevant roxygen headers and examples, including keywords
    and families. Refer to the
    categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the
    NAMESPACE file in the project root are updated appropriately
  • (Did not feel any updates needed for vignettes) Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it
    has an @export tag) or documentation aimed at users (rather than developers)
  • (had some errors with installing Pandoc so could not run this) Build oak site pkgdown::build_site() and check that all affected
    examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • (had some errors with installing Pandoc so could not run this) Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

    but cal_min_max_date may refer to date variables and time variables that are not in a string format.
    For example, the date may be a Date object, and the time may be an hms object, if the haven::read_sas() function was used to convert a sas dataset into an R dataframe.
    So we make a small adjustment to allow for Date objects and hms time objects.
…ax_dates in the previous commit, since oak_cal_ref_dates uses cal_min_max_date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Product Backlog

Development

Successfully merging this pull request may close these issues.

1 participant