(Closes issue #131) Make cal_min_max_date (and by extension oak_cal_ref_dates) work with Date objects and hms time objects (not just character date and time strings) #135
Task list completed / task-list-completed
Started
2025-12-08 12:23:54
ago
9 / 14 tasks completed
5 tasks still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
| Place Closes #<insert_issue_number> into the beginning of your Pull z | |
| Request Title (Use Edit button in top-right if you need to update) | Completed |
| Code is formatted according to the | |
| tidyverse style guide. Run | |
styler::style_file() to style R and Rmd files |
Completed |
| Updated relevant unit tests or have written new unit tests, which should | |
| consider realistic data scenarios and edge cases, e.g. empty datasets, errors, | |
| boundary cases etc. - See | |
| Unit Test Guide | Completed |
| (Did not remove/place functions or parameters) If you removed/replaced any function and/or function parameters, did you | |
| fully follow the | |
| deprecation guidance? | Incomplete |
| (Did not create any functions) Update to all relevant roxygen headers and examples, including keywords | |
| and families. Refer to the | |
| categorization of functions to tag appropriate keyword/family. | Incomplete |
Run devtools::document() so all .Rd files in the man folder and the |
|
NAMESPACE file in the project root are updated appropriately |
Completed |
| (Did not feel any updates needed for vignettes) Address any updates needed for vignettes and/or templates | Incomplete |
Update NEWS.md if the changes pertain to a user-facing function (i.e. it |
|
has an @export tag) or documentation aimed at users (rather than developers) |
Completed |
(had some errors with installing Pandoc so could not run this) Build oak site pkgdown::build_site() and check that all affected |
|
| examples are displayed correctly and that all new functions occur on the "Reference" page. | Incomplete |
Address or fix all lintr warnings and errors - lintr::lint_package() |
Completed |
(had some errors with installing Pandoc so could not run this) Run R CMD check locally and address all errors and warnings - devtools::check() |
Incomplete |
| Link the issue in the Development Section on the right hand side. | Completed |
| Address all merge conflicts and resolve appropriately | Completed |
| Pat yourself on the back for a job well done! Much love to your accomplishment! | Completed |
Loading