feat!: remove function device started from ble proto files #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your first PR. We really appreciate it! |
Contributor
Dependency ReviewThe following issues were found:
Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issuesexternal/crypto/tiny-aes128/CMakeLists.txt
cmake/emil_test_helpers.cmake
external/protobuf/CMakeLists.txt
infra/syntax/CMakeLists.txt
external/segger_rtt/CMakeLists.txt
external/crypto/mbedtls/CMakeLists.txt
external/crypto/micro-ecc/CMakeLists.txt
osal/freertos/CMakeLists.txt
osal/threadx/CMakeLists.txt
lwip/lwip/CMakeLists.txt
external/args/CMakeLists.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0 | 0.39s | |
| ✅ CPP | clang-format | 1043 | 9 | 0 | 0 | 8.24s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.42s | |
| ✅ JSON | jsonlint | 7 | 0 | 0 | 0.15s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.61s |
| markdownlint | 6 | 0 | 4 | 0 | 1.19s | |
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0 | 0.35s |
| ✅ REPOSITORY | checkov | yes | no | no | 22.94s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.05s | |
| ✅ REPOSITORY | grype | yes | no | no | 27.17s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.06s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 7.4s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.53s | |
| ✅ REPOSITORY | trivy | yes | no | no | 7.65s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.18s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.33s | |
| lychee | 139 | 63 | 0 | 23.88s | ||
| prettier | 22 | 1 | 1 | 0 | 0.78s | |
| ✅ YAML | v8r | 22 | 0 | 0 | 7.33s | |
| ✅ YAML | yamllint | 22 | 0 | 0 | 0.67s |
Detailed Issues
⚠️ SPELL / lychee - 63 errors
[404] https://github.com/protocolbuffers/protobuf/releases/download/v$%7Bprotobuf_tag%7D/protoc-$%7Bprotobuf_version%7D-$%7Bos_postfix%7D.zip | Network error: Not Found
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/747 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/840 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/792 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/781 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/802 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/651 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/671 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/699 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/665 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/808 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/612 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/830 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/300 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/753 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/748 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/803 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/530 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/658 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/850 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/844 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/compare/v2.2.1...v3.0.0 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/linting-formatting.yml | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/524 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/ci.yml | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/609 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/749 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/static-analysis.yml/badge.svg | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/237 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/linting-formatting.yml/badge.svg | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/static-analysis.yml | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/Taywee/args | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/ci.yml/badge.svg?branch=main | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/688 | Network error: Too Many Requests
[429] https://github.com/kmackay/micro-ecc | Network error: Too Many Requests
[429] https://github.com/protocolbuffers/protobuf/issues/9817 | Network error: Too Many Requests
[429] https://github.com/SEGGERMicro/RTT | Network error: Too Many Requests
[429] https://github.com/Mbed-TLS/mbedtls | Network error: Too Many Requests
[429] https://github.com/Mbed-TLS/mbedtls/pull/6966 | Network error: Too Many Requests
[429] https://github.com/protocolbuffers/protobuf | Network error: Too Many Requests
[429] https://github.com/FreeRTOS/FreeRTOS-Kernel | Network error: Too Many Requests
[429] https://github.com/zeux/pugixml | Network error: Too Many Requests
[429] https://github.com/eclipse-threadx/threadx | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/677 | Network error: Too Many Requests
[429] https://github.com/lwip-tcpip/lwip | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/267 | Network error: Too Many Requests
📝 Summary
---------------------
🔍 Total..........439
✅ Successful.....373
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........3
❓ Unknown..........0
🚫 Errors..........63
Errors in README.md
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/linting-formatting.yml | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/ci.yml | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/linting-formatting.yml/badge.svg | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/ci.yml/badge.svg?branch=main | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/static-analysis.yml | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/actions/workflows/static-analysis.yml/badge.svg | Network error: Too Many Requests
Errors in osal/threadx/CMakeLists.txt
[429] https://github.com/eclipse-threadx/threadx | Network error: Too Many Requests
Errors in external/protobuf/CMakeLists.txt
[429] https://github.com/protocolbuffers/protobuf | Network error: Too Many Requests
[429] https://github.com/protocolbuffers/protobuf/issues/9817 | Network error: Too Many Requests
Errors in infra/syntax/CMakeLists.txt
[429] https://github.com/zeux/pugixml | Network error: Too Many Requests
Errors in osal/freertos/CMakeLists.txt
[429] https://github.com/FreeRTOS/FreeRTOS-Kernel | Network error: Too Many Requests
Errors in lwip/lwip/CMakeLists.txt
[429] https://github.com/lwip-tcpip/lwip | Network error: Too Many Requests
Errors in external/args/CMakeLists.txt
[429] https://github.com/Taywee/args | Network error: Too Many Requests
Errors in CHANGELOG.md
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/808 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/688 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/612 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/850 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/749 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/658 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/651 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/671 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/781 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/300 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/802 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/792 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/844 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/237 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/267 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/830 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/530 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/665 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/747 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/699 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/677 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/commit/HIDDEN_BY_MEGALINTER| Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/803 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-infra-lib/issues/840 | Network error: Too Many Requests
[429] https://github.com/philips-software/amp-embedded-i
(Truncated to 13333 characters out of 15029)
⚠️ MARKDOWN / markdownlint - 4 errors
external/crypto/tiny-aes128/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "### Tiny AES128 in C"]
external/crypto/tiny-aes128/README.md:29 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:39 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
external/crypto/tiny-aes128/README.md:49 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
⚠️ YAML / prettier - 1 error
[error] Explicitly specified pattern "documents/modules/ROOT/examples/clangformat.yaml" is a symbolic link.
.clusterfuzzlite/project.yaml 39ms (unchanged)
.github/dependabot.yml 25ms (unchanged)
.github/workflows/ci.yml 93ms (unchanged)
.github/workflows/dependency-scanner.yml 13ms (unchanged)
.github/workflows/documentation.yml 19ms (unchanged)
.github/workflows/fuzzing-batch.yml 6ms (unchanged)
.github/workflows/fuzzing-cron.yml 8ms (unchanged)
.github/workflows/fuzzing-pr.yml 5ms (unchanged)
.github/workflows/linting-formatting.yml 17ms (unchanged)
.github/workflows/release-please.yml 9ms (unchanged)
.github/workflows/security.yml 6ms (unchanged)
.github/workflows/social-interaction.yml 3ms (unchanged)
.github/workflows/static-analysis.yml 11ms (unchanged)
.github/workflows/validate-pr.yml 12ms (unchanged)
.ls-lint.yml 4ms
.mega-linter.yml 3ms (unchanged)
antora-playbook-branch.yml 3ms (unchanged)
antora-playbook-site.yml 3ms (unchanged)
documents/antora.yml 2ms (unchanged)
documents/supplemental-ui/ui.yml 1ms (unchanged)
mull.yml 1ms (unchanged)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
|
heinwessels-philips
requested changes
Jan 9, 2026
| option (service_id) = 34; | ||
|
|
||
| rpc Done(Nothing) returns (Nothing) { option (method_id) = 1; } | ||
| rpc DeviceStarted(Nothing) returns (Nothing) { option (method_id) = 2; } |
Contributor
There was a problem hiding this comment.
I still need to have a discussion with Richard on when our proto files should maintain clean backwards compatibility. But until then I believe it would be better to do it just in case. So could you maintain the old method_ids, and reserved the removed one? For example:
Suggested change
| rpc DeviceStarted(Nothing) returns (Nothing) { option (method_id) = 2; } | |
| reserved 2; | |
| reserved "DeviceStarted"; | |
| rpc StateChanged(State) returns (Nothing) { option (method_id) = 3; } |
Contributor
Author
There was a problem hiding this comment.
It doesn't make sense to me. It isn't compatible anyway—it uses a different proto file and a different service.
Contributor
Author
There was a problem hiding this comment.
Oh, sorry—I thought your comment was on a different repo. Here, I do agree with your comment.
| rpc PairingSuccessfullyCompleted(Nothing) returns (Nothing) { option (method_id) = 4; } | ||
| rpc PairingFailed(PairingStatus) returns (Nothing) { option (method_id) = 5; } | ||
| rpc NumberOfBondsChanged(UInt32Value) returns (Nothing) { option (method_id) = 6; } | ||
| rpc DeviceStarted(Nothing) returns (Nothing) { option (method_id) = 7; } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.