Skip to content

feat!: remove function device started from ble proto files #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gabrielsantosphilips wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat!: remove function device started from ble proto files #1060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions services/ble/Gap.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,12 +274,11 @@ service GapPeripheralResponse
option (service_id) = 34;

rpc Done(Nothing) returns (Nothing) { option (method_id) = 1; }
rpc DeviceStarted(Nothing) returns (Nothing) { option (method_id) = 2; }
Copy link
Contributor

@heinwessels-philips heinwessels-philips Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to have a discussion with Richard on when our proto files should maintain clean backwards compatibility. But until then I believe it would be better to do it just in case. So could you maintain the old method_ids, and reserved the removed one? For example:

Suggested change
rpc DeviceStarted(Nothing) returns (Nothing) { option (method_id) = 2; }
reserved 2;
reserved "DeviceStarted";
rpc StateChanged(State) returns (Nothing) { option (method_id) = 3; }

Copy link
Contributor Author

@gabrielsantosphilips gabrielsantosphilips Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense to me. It isn't compatible anyway—it uses a different proto file and a different service.

Copy link
Contributor Author

@gabrielsantosphilips gabrielsantosphilips Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry—I thought your comment was on a different repo. Here, I do agree with your comment.

rpc StateChanged(State) returns (Nothing) { option (method_id) = 3; }
rpc ResolvableAddress(Address) returns (Nothing) { option (method_id) = 4; }
rpc DisplayPasskey(Passkey) returns (Nothing) { option (method_id) = 5; }
rpc IdentityAddress(Address) returns (Nothing) { option (method_id) = 6; }
rpc OutOfBandDataGenerated(OutOfBandData) returns (Nothing) { option (method_id) = 7; }
rpc StateChanged(State) returns (Nothing) { option (method_id) = 2; }
rpc ResolvableAddress(Address) returns (Nothing) { option (method_id) = 3; }
rpc DisplayPasskey(Passkey) returns (Nothing) { option (method_id) = 4; }
rpc IdentityAddress(Address) returns (Nothing) { option (method_id) = 5; }
rpc OutOfBandDataGenerated(OutOfBandData) returns (Nothing) { option (method_id) = 6; }
}

service GapCentralResponse
Expand All @@ -292,9 +291,8 @@ service GapCentralResponse
rpc PairingSuccessfullyCompleted(Nothing) returns (Nothing) { option (method_id) = 4; }
rpc PairingFailed(PairingStatus) returns (Nothing) { option (method_id) = 5; }
rpc NumberOfBondsChanged(UInt32Value) returns (Nothing) { option (method_id) = 6; }
rpc DeviceStarted(Nothing) returns (Nothing) { option (method_id) = 7; }
Copy link
Contributor

@heinwessels-philips heinwessels-philips Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

rpc ResolvedPrivateAddress(Address) returns (Nothing) { option (method_id) = 8; }
rpc ResolvePrivateAddressFailed(Nothing) returns (Nothing) { option (method_id) = 9; }
rpc DeviceBonded(BoolValue) returns (Nothing) { option (method_id) = 10; }
rpc OutOfBandDataGenerated(OutOfBandData) returns (Nothing) { option (method_id) = 11; }
rpc ResolvedPrivateAddress(Address) returns (Nothing) { option (method_id) = 7; }
rpc ResolvePrivateAddressFailed(Nothing) returns (Nothing) { option (method_id) = 8; }
rpc DeviceBonded(BoolValue) returns (Nothing) { option (method_id) = 9; }
rpc OutOfBandDataGenerated(OutOfBandData) returns (Nothing) { option (method_id) = 10; }
}
Loading