Skip to content

prevent crash when passing * to ignore_attributes (#3997) #8926

prevent crash when passing * to ignore_attributes (#3997)

prevent crash when passing * to ignore_attributes (#3997) #8926

Triggered via push September 18, 2025 13:28
Status Success
Total duration 6m 16s
Artifacts 9

ci.yml

on: push
Matrix: e2e test
Matrix: mix_test
Matrix: npm test
Matrix: coverage report
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 10 warnings, and 1 notice
[webkit] › tests/js.spec.js:4:1 › toggle_attribute: test/e2e/tests/js.spec.js#L14
2) [webkit] › tests/js.spec.js:4:1 › toggle_attribute ──────────────────────────────────────────── Error: expect(received).toEqual(expected) // deep equality Expected: ArrayContaining [{"attr": "style", "newValue": "display: block;", "oldValue": "display: none;"}, {"attr": "aria-expanded", "newValue": "true", "oldValue": "false"}, {"attr": "open", "newValue": "true", "oldValue": null}, ObjectContaining {"attr": "class", "newValue": "fade-in"}, ObjectContaining {"attr": "class", "oldValue": "fade-in"}] Received: [{"attr": "aria-expanded", "newValue": "true", "oldValue": "false"}, {"attr": "aria-expanded", "newValue": "true", "oldValue": "true"}, {"attr": "open", "newValue": "true", "oldValue": null}, {"attr": "class", "newValue": "fade-in", "oldValue": null}, {"attr": "style", "newValue": "display: block;", "oldValue": "display: none;"}] 12 | // wait for the transition time (set to 50) 13 | await page.waitForTimeout(100); > 14 | expect(await changes()).toEqual( | ^ 15 | expect.arrayContaining([ 16 | { 17 | attr: "style", at /__w/phoenix_live_view/phoenix_live_view/test/e2e/tests/js.spec.js:14:27
[firefox] › tests/errors.spec.js:265:5 › exception handling › after connected mount › parent crashes and reconnects when linked child LV crashes: test/e2e/tests/errors.spec.js#L273
1) [firefox] › tests/errors.spec.js:265:5 › exception handling › after connected mount › parent crashes and reconnects when linked child LV crashes Error: expect(received).toEqual(expected) // deep equality Expected: ArrayContaining [StringMatching /mount/, StringMatching /child error: unable to join/, StringMatching /child destroyed/, StringMatching /error: view crashed/, StringMatching /mount/, StringMatching /child mount/] Received: ["phx-GGZjmwZzRld5Z5Mh mount: - JSHandle@object", "child error: unable to join - JSHandle@object", "child destroyed: the child has been removed from the parent - undefined", "phx-GGZjmwZzRld5Z5Mh error: view crashed - JSHandle@object", "phx-GGZjmwZzRld5Z5Mh mount: - JSHandle@object"] 271 | // child crashed on mount, linked to parent -> parent crashed too 272 | // second mounts are successful > 273 | expect(consoleMessages).toEqual( | ^ 274 | expect.arrayContaining([ 275 | expect.stringMatching(/mount/), 276 | expect.stringMatching(/child error: unable to join/), at /__w/phoenix_live_view/phoenix_live_view/test/e2e/tests/errors.spec.js:273:31
npm test (1.18.4, 27.3): test/e2e/tests/issues/3083.spec.js#L29
Unexpected use of page.waitForTimeout()
npm test (1.18.4, 27.3): test/e2e/tests/forms.spec.js#L134
Avoid calling `expect` conditionally`
npm test (1.18.4, 27.3): test/e2e/tests/forms.spec.js#L133
Avoid having conditionals in tests
npm test (1.18.4, 27.3): test/e2e/tests/errors.spec.js#L147
Unexpected use of page.waitForTimeout()
npm test (1.18.4, 27.3): test/e2e/tests/errors.spec.js#L118
Unexpected use of page.waitForTimeout()
npm test (1.18.4, 27.3): test/e2e/tests/errors.spec.js#L67
Unexpected use of page.waitForTimeout()
npm test (1.18.4, 27.3): test/e2e/tests/components.spec.js#L77
Unexpected use of the `.skip()` annotation
npm test (1.18.4, 27.3): test/e2e/tests/components.spec.js#L76
Avoid having conditionals in tests
npm test (1.18.4, 27.3): test/e2e/tests/components.spec.js#L36
Unexpected use of the `.skip()` annotation
npm test (1.18.4, 27.3): test/e2e/tests/components.spec.js#L35
Avoid having conditionals in tests
🎭 Playwright Run Summary
2 flaky [firefox] › tests/errors.spec.js:265:5 › exception handling › after connected mount › parent crashes and reconnects when linked child LV crashes [webkit] › tests/js.spec.js:4:1 › toggle_attribute ───────────────────────────────────────────── 3 skipped 442 passed (3.9m)

Artifacts

Produced during runtime
Name Size Digest
e2e-test-results Expired
4.25 MB
sha256:3aa1f3858dd3ac40c8f6dbe6476ba892fed08e5b03f68cf745188cfa9e839ca7
js-unit-coverage Expired
853 KB
sha256:0e9716e3108e5d93057caa0c640d4e99c7d2a08a29d23c239bea311d65f0c2f7
mix-e2e-coverage Expired
107 KB
sha256:718d2f1851193f9db24f98fb80181fb27d6520659ecaac3f4520f6c3bcfee044
mix-test-coverage-25.3-1.15.4 Expired
156 KB
sha256:9a42f16c06fc627413dc2c646cfb040ae1a3c7413a10d4db5fc2d9ef0a912dd9
mix-test-coverage-26.2-1.16.3 Expired
154 KB
sha256:bb3969bed51a0df16b063069a739070f0e4c27007948cb8a84527786402782fe
mix-test-coverage-27.3-1.18.4 Expired
103 KB
sha256:741fb68f15250228211ba0d1441fe330507f2a26d9459bcf4e346e9faa6b16df
mix-test-coverage-maint-28-main-otp-28 Expired
103 KB
sha256:edd342e887b3f8201b5a622824e87a751e343c6218859cd1dc6ea53492d5c681
overall-coverage Expired
1.56 MB
sha256:318b8920712a2d9f23cda28ad951e764e332559202757028c46f2ef0f16f0bb3
playwright-report Expired
1.1 MB
sha256:68b30c8de07b248620c641a4f9bd655fe807d128bb04fbf9d3afa4fce303fb3f