prevent crash when passing * to ignore_attributes (#3997) #8926
Annotations
2 errors and 1 notice
Run e2e tests:
test/e2e/tests/js.spec.js#L14
2) [webkit] › tests/js.spec.js:4:1 › toggle_attribute ────────────────────────────────────────────
Error: expect(received).toEqual(expected) // deep equality
Expected: ArrayContaining [{"attr": "style", "newValue": "display: block;", "oldValue": "display: none;"}, {"attr": "aria-expanded", "newValue": "true", "oldValue": "false"}, {"attr": "open", "newValue": "true", "oldValue": null}, ObjectContaining {"attr": "class", "newValue": "fade-in"}, ObjectContaining {"attr": "class", "oldValue": "fade-in"}]
Received: [{"attr": "aria-expanded", "newValue": "true", "oldValue": "false"}, {"attr": "aria-expanded", "newValue": "true", "oldValue": "true"}, {"attr": "open", "newValue": "true", "oldValue": null}, {"attr": "class", "newValue": "fade-in", "oldValue": null}, {"attr": "style", "newValue": "display: block;", "oldValue": "display: none;"}]
12 | // wait for the transition time (set to 50)
13 | await page.waitForTimeout(100);
> 14 | expect(await changes()).toEqual(
| ^
15 | expect.arrayContaining([
16 | {
17 | attr: "style",
at /__w/phoenix_live_view/phoenix_live_view/test/e2e/tests/js.spec.js:14:27
|
Run e2e tests:
test/e2e/tests/errors.spec.js#L273
1) [firefox] › tests/errors.spec.js:265:5 › exception handling › after connected mount › parent crashes and reconnects when linked child LV crashes
Error: expect(received).toEqual(expected) // deep equality
Expected: ArrayContaining [StringMatching /mount/, StringMatching /child error: unable to join/, StringMatching /child destroyed/, StringMatching /error: view crashed/, StringMatching /mount/, StringMatching /child mount/]
Received: ["phx-GGZjmwZzRld5Z5Mh mount: - JSHandle@object", "child error: unable to join - JSHandle@object", "child destroyed: the child has been removed from the parent - undefined", "phx-GGZjmwZzRld5Z5Mh error: view crashed - JSHandle@object", "phx-GGZjmwZzRld5Z5Mh mount: - JSHandle@object"]
271 | // child crashed on mount, linked to parent -> parent crashed too
272 | // second mounts are successful
> 273 | expect(consoleMessages).toEqual(
| ^
274 | expect.arrayContaining([
275 | expect.stringMatching(/mount/),
276 | expect.stringMatching(/child error: unable to join/),
at /__w/phoenix_live_view/phoenix_live_view/test/e2e/tests/errors.spec.js:273:31
|
Run e2e tests
2 flaky
[firefox] › tests/errors.spec.js:265:5 › exception handling › after connected mount › parent crashes and reconnects when linked child LV crashes
[webkit] › tests/js.spec.js:4:1 › toggle_attribute ─────────────────────────────────────────────
3 skipped
442 passed (3.9m)
|
Loading