This repository was archived by the owner on Sep 4, 2020. It is now read-only.
[DRAFT] feat: remove cordova-support-google-services dependency#2873
Open
erisu wants to merge 1 commit intophonegap:masterfrom
erisu:feat/remove-cordova-support-google-services
Open
[DRAFT] feat: remove cordova-support-google-services dependency#2873erisu wants to merge 1 commit intophonegap:masterfrom erisu:feat/remove-cordova-support-google-services
erisu wants to merge 1 commit intophonegap:masterfrom
erisu:feat/remove-cordova-support-google-services
Conversation
3 tasks
|
Is there an ETA for this merge? cordova-android@9.0.0 has already released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
cordova-support-google-servicesdependencyRelated Issue
Issue will be created at a later time. This PR is current set to draft and will not be ready to merge until Cordova Android release.
Motivation and Context
The next version of Cordova Android will have
preferenceoptions to enable Google Services and the ability to define which versions of Google Services to use.With this new feature, having this plugin inject to the into the Gradle build process causes build failures. This dependency will no longer be needed.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Will review each item and update accordingly before PR is open from draft mode.