Merged
Conversation
- Add appearance fields to CharacterSummaryResponse (skinColor, hairColor, eyeColor, faceShape, hairStyle, eyeShape, noseShape, mouthShape)
- Add duplicate character endpoint POST /api/characters/{id}/duplicate
- Add toggle share endpoint POST /api/characters/{id}/toggle-share
- Add name availability endpoint GET /api/characters/check-name
- Add MapToSummaryResponse method for consistent mapping
- Add unit and integration tests for new features
- Add CharacterCard component with MiniPreview (character silhouette) - Add always-visible action buttons (edit, duplicate, delete, share) - Add MiniPreview component with memoization and typed configs - Add reusable Icon base component and CharacterIcons - Add DeleteConfirmModal and DuplicateModal components - Add character duplicate, delete, toggle share functionality - Extend CharacterSummary interface with appearance fields - Add comprehensive tests for all new components
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add appearance fields to CharacterSummaryResponse (skinColor, hairColor, eyeColor, faceShape, hairStyle, eyeShape, noseShape, mouthShape)
- Add duplicate character endpoint POST /api/characters/{id}/duplicate
- Add toggle share endpoint POST /api/characters/{id}/share
- Add name availability endpoint GET /api/characters/check-name
- Add MapToSummaryResponse method for consistent mapping
- Fix integration tests: add ClassId to Character entities
- Fix Duplicate tests: send proper request body with Name
- Add CharacterCard component with MiniPreview (character silhouette) - Add always-visible action buttons (edit, duplicate, delete, share) - Add MiniPreview component with memoization and typed configs - Add reusable Icon base component and CharacterIcons - Add DeleteConfirmModal and DuplicateModal components - Add character duplicate, delete, toggle share functionality - Extend CharacterSummary interface with appearance fields - Add comprehensive tests for all new components
pierrick-fonquerne
force-pushed
the
62-dashboard-utilisateur
branch
from
a4b199e to
dad7019
Compare
The test was clicking submit before isAvailable was set to true, causing intermittent failures in CI. Now waits for "Ce nom est disponible" message to appear before clicking Dupliquer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.