ddl code refactor/optimize

[D3Hunter]

Enhancement

We have listed a lot of items that we want to refactor, to make the structure more clear and code easier to maintain and extend, and some optimize tasks to make general DDL run faster. And in the last 8.2 sprint, we optimized for general DDL, and done some refactor for job scheduling and have left some TODOs during the refactor, #53246.
In 8.3 sprint, we have the same goal as in 8.2 and we also want to enhance testibility of DDL component, by decoupling different part of DDL(TODO), and replacing ddl.Hook with simplier failpoint.

Decouple components of DDL

Currently, ddl/ddlCtx is quite large and has a lot of responsibility, including:

• handle job submission which come from sql executor, this is the biggest part
  • This part shares the same interface as schema-tracker, maybe extract this interface as something called DDLExecutor.
• Handle local ddl job execution for fast creating tables. It runs on every node
• owner election, start job scheduler
• Enable/disable some functions, such as whether this node can attend owner election, and fast-create
• It contains a lot of methods related to job execution, such as writePhysicalTableRecord
• Manages fields which are shared with other components, such as below. They only use part of their function, and there are no intersections. Maybe we can create those fields on each side or separate the function.
  • SchemaSyncer, or should be called schema-version-syncer, shared with domain
  • StateSyncer, shared with SyncUpgrade api handling.
• Manages fields that should be part of job scheduler: reorg-ctx/job-ctx/ddlSeqNum/waitSchemaSyncedController
• Some fields are used for unit tests: hook/interceptor inside ddlCtx. We can replace them with failpoints.
• Some util methods which should be moved out: GetTableMaxHandle

Tasks

• Optimize job execution
  • remove this markJobProcessing completely, we have move job dependency calculation in memory, and as long as the job resides in the table, we should try run it, so this fields is useless now. see ddl: schedule as many jobs as possible in one round, simplify sql to query jobs #54438
  • merge loadDDLJobAndRun by job type into one(we have do it in this ddl: consider paused job when check runnable #54419), and remove the sub-query in getJobSQL, and handle this case ddl: support referring objects in runningJobs #54110 (comment) . And schedule as many jobs as possible in one round. see ddl: schedule as many jobs as possible in one round, simplify sql to query jobs #54438
  • infoschema: use maps.Clone to replace iterating #54581
  • Make job id allocation and insert job run in one transaction, and test QPS of it when run in parallel. If it outperforms job execution, we can re-add the reverted optimization that query from the min job id.
    • ddl: pessimistic lock global id, alloc id & insert ddl job in one txn #54547
    • ddl: combine table/partition/db id allocation with job id #54669
    • ddl: query since min job id #54693
  • ddl: integrate fast create table into normal general DDL workflow #55025
    • ddl: remove unused code related to prev fast create impl #55116
  • [later]Use RPC to notify job done when DDL job is submitted on non-owner node.
• Decouple components of DDL
  • Move waitSchemaSyncedController / reorgCtx / jobCtx / ddlSeqNum / schemaVersionManager to job scheduler from ddlCtx
    • ddl: decouple job seq number from job history & reset its allocator on owner change #54774
    • ddl: move structs related to scheduler out from ddlCtx & add job context #55411
    • ddl: abstract job submitter & move some fields from ddlCtx to jobContext #55461
    • meta: separate reader and mutator #56376
    • ddl: make meta mutator part of jobContext #56399
  • Separate DDLExecutor interface out of DDL interface
    • ddl: decouple executor part out from ddl #54858
    • ddl: re-structure ddl executor part 2 #55140
  • separate local job execution out: we have integrate fast-create into general DDL, see ddl: integrate fast create table into normal general DDL workflow #55025
  • Moving methods related to job execution out ddl: decouple executor part out from ddl #54858
  • Avoid exposing SchemaSyncer and StateSyncer from DDL
  • Replace fields only used for test with failpoint: such as hook/interceptor inside ddlCtx
    • ddl: remove interceptor and replace some hook with failpoint #54882
    • ddl: replace OnJobUpdated callback with failpoint #55091
    • ddl: replace OnJobRunAfter callback with failpoint #55120
    • *: replace ddl callback injection with failpoint #55215
  • Move GetTableMaxHandle out ddl: move structs related to scheduler out from ddlCtx & add job context #55411
  • ddl/domain: disallow set schema lease to 0 #55312
  • ddl: restructure schema version and server state syncer #55368
  • ddl: alloc global id together with job id #55552
• Refactor for reorg jobs (TODO, only list a few)
  • make all global variables like ingest.LitBackCtxMgr local to job scheduler
  • ReorgCtx is stored at ddlCtx, and we are waiting for the reorg routine repeatedly by entering/exit the ddl worker. If after the check due to waitTimeout, owner changes, we might have no chance to clean it up. We better wait for the routine inside runReorgJob
  • Remove dependency on lightning config, we should use local.BackendConfig directly. ddl: directly use BackendConfig rather than use lightning config #55433
  • ddl: replace local ingest impl with backfill operators #54149
  • ddl/ingest: move backend ctx out of checkpoint manager #54292
  • ddl: load table ranges from PD instead of region cache #54598
  • ddl/ingest: refactor checkpoint manager #54747
  • ddl: remove unused copReqSenderPool and related structures #55302
• improve the usability of DDL Job.Args #53930
  • *: move annotated attributes of AST node to resolve.Context #55634
  • *: move XXInfo/Job, etc, out from model pkg in parser to meta #55754
  • ddl: add job version 2 and use typed args for truncate table #55854
  • ddl: args v2 for create/drop/modify schema #55919
  • ddl: args v2 for create table/view/sequence, batch create table #55964
  • ddl: args v2 for create/alter/drop resource group #56153
  • ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Partition #56163
  • ddl: args v2 for drop table/view/sequence #56219
  • ddl: fix panic in TablePartitionArgs v2 #56222
  • ddl: detect tidb version to determine job version to use, add scripts to run V1 separately #56242
  • ddl: args v2 for truncate/exchange/alter partition #56269
  • ddl: use JobArgs in job wrapper and use doDDLJob2 for some job type #56400
  • ddl: use golang tags to force job args v1 in CI #56417
  • ddl: args v2 for rename tables #55946
  • ddl: args v2 for add/drop/alter CheckConstraint #56010
  • ddl: args v2 for add/drop/rename index/primary key #56130
  • ddl: args v2 for create/alter/drop placement policy  #56186
  • ddl: args v2 for lock/unlock/repair table and recover table/schema #56194
  • ddl: arg v2 for flashback cluster and alter table attributes #56290
  • ddl: refactor the args for the DDL type of renametable #55959
  • ddl: refactor V2 job args of dropping column DDL. #56021
  • ddl: refactor V2 args for RebaseAutoID/Modify-table/Index-visibility/FK related DDL. #56164
  • ddl: refactor job args for alter sequence/auto-id-cache/shard-rowid/cache/ttl related ddl job. #56206
  • ddl: refactor job args for set/update tiflash-replica and alter-table-placement ddl #56241
  • ddl: refactor job args for set-default-value/add column ddl. #56337
• refine the context and context-like struct usage in DDL #56398
• others
  • ddl: fix a caught panic and add comment for DDL functions #54685
  • ddl: re-structure job scheduler and ddl executor, part 1 #54967
  • ddl: watch the ddl ownerkey with the createRevision #55692
  • ddl: fetch schemas in work pool in case of reporting a error in one goroutine.  #55841