-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: move XXInfo/Job, etc, out from model pkg in parser to meta #55754
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55754 +/- ##
=================================================
- Coverage 72.7958% 57.1025% -15.6933%
=================================================
Files 1588 1748 +160
Lines 443469 631574 +188105
=================================================
+ Hits 322827 360645 +37818
- Misses 100772 246003 +145231
- Partials 19870 24926 +5056
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -2302,29 +2302,21 @@ func (n *ResourceGroupOption) Restore(ctx *format.RestoreCtx) error { | |||
return nil | |||
} | |||
|
|||
type RunawayOptionType int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this type is redefined in model/model.go, introduced in #43843
see
https://github.com/pingcap/tidb/pull/43843/files#diff-ee2e401594b744a2daae48119d71fdff0022c3a59b58eaf30a12e37009eede60R2187-R2193
and https://github.com/pingcap/tidb/pull/43843/files#diff-798c1c7a69a59b2fba339f230d6b764dbffe9ddc80cff6eb526139f621f7c225R1885-R1891
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you move model pkg out of parser, I'm not sure whether some other repos that depencies on the parser will break...
@bb7133 could you take a look?
I checked some outer dependency of parser, they only depends on AST and model.CIStr, those part are not moved. I have already described it in the PR, ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, hawkingrei, joccau, lance6716, lcwangchao, tangenta, tiancaiamao, windtalker, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-lightning-integration-test |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #54436
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.