ddl: arg v2 for flashback cluster and alter table attributes #56290

joechenrh · 2024-09-25T07:46:45Z

What problem does this PR solve?

Issue Number: Ref #53930 #54436

Problem Summary:

What changed and how does it work?

As title.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-09-25T07:47:01Z

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-09-26T02:23:02Z

Codecov Report

Attention: Patch coverage is 75.55556% with 33 lines in your changes missing coverage. Please review.

Project coverage is 76.2530%. Comparing base (3922a4b) to head (0da38ef).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56290        +/-   ##
================================================
+ Coverage   73.3869%   76.2530%   +2.8661%     
================================================
  Files          1623       1645        +22     
  Lines        447156     455680      +8524     
================================================
+ Hits         328154     347470     +19316     
+ Misses        98887      86705     -12182     
- Partials      20115      21505      +1390

Flag	Coverage Δ
integration	`52.2845% <51.1111%> (?)`
unit	`72.6677% <66.6666%> (+0.1870%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.2343% <ø> (+17.7068%)`	⬆️

pkg/meta/model/job_args.go

D3Hunter · 2024-09-27T04:21:02Z

pkg/meta/model/job_args.go

+		if !a.EnableAutoAnalyze {
+			job.Args[3] = "OFF"
+		}
+		if !a.SuperReadOnly {
+			job.Args[4] = "OFF"
+		}
+		if !a.EnableTTLJob {
+			job.Args[8] = "OFF"
+		}


prefer we name and value for args 3/4/8, and move this above job.Args = []any

pkg/meta/model/job_args.go

pkg/meta/model/job_test.go

D3Hunter

rest lgtm

pkg/ddl/cluster.go

pkg/meta/model/job_args_test.go

pkg/ddl/executor.go

joccau

rest lgtm

joccau

LGTM

ti-chi-bot · 2024-09-29T06:25:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, joccau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/ddl/OWNERS~~ [D3Hunter]
~~pkg/meta/OWNERS~~ [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-09-29T06:26:01Z

[LGTM Timeline notifier]

Timeline:

2024-09-27 10:41:52.818887169 +0000 UTC m=+5868.239100181: ☑️ agreed by D3Hunter.
2024-09-29 06:26:00.870755376 +0000 UTC m=+163316.290968388: ☑️ agreed by joccau.

D3Hunter · 2024-09-29T08:37:09Z

/retest

tiprow · 2024-09-29T08:37:29Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-29T09:01:13Z

/retest

tiprow · 2024-09-29T09:01:33Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-29T09:55:39Z

/retest

tiprow · 2024-09-29T09:56:00Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-29T12:08:40Z

/retest

tiprow · 2024-09-29T12:09:01Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-29T12:51:51Z

/retest

tiprow · 2024-09-29T12:52:13Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-29T14:09:51Z

/retest

tiprow · 2024-09-29T14:10:13Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joechenrh added 2 commits September 24, 2024 18:51

test

608879a

Update

3bf37d6

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 25, 2024

joechenrh added 3 commits September 25, 2024 16:12

Rename fields

0b0d577

Minor fix

23ebb55

Merge branch 'master' into addargs-flaskbackcluster

e5b12cd

D3Hunter reviewed Sep 27, 2024

View reviewed changes

Address comment

7c74f1f

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024

D3Hunter reviewed Sep 27, 2024

View reviewed changes

pkg/ddl/cluster.go Show resolved Hide resolved

D3Hunter approved these changes Sep 27, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2024

joccau reviewed Sep 27, 2024

View reviewed changes

pkg/meta/model/job_args_test.go Outdated Show resolved Hide resolved

joccau reviewed Sep 27, 2024

View reviewed changes

pkg/ddl/executor.go Outdated Show resolved Hide resolved

joccau reviewed Sep 27, 2024

View reviewed changes

joechenrh added 2 commits September 29, 2024 08:54

Address comments

d36a03f

Merge branch 'master' into addargs-flaskbackcluster

17e665f

joechenrh requested a review from joccau September 29, 2024 01:01

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2024

joccau approved these changes Sep 29, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2024

joechenrh added 2 commits September 29, 2024 14:27

Merge branch 'master' into addargs-flaskbackcluster

ff2c869

Merge branch 'master' into addargs-flaskbackcluster

0da38ef

ti-chi-bot bot merged commit 3ee8765 into pingcap:master Sep 29, 2024
23 checks passed

D3Hunter mentioned this pull request Sep 30, 2024

ddl code refactor/optimize #54436

Open

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: arg v2 for flashback cluster and alter table attributes #56290

ddl: arg v2 for flashback cluster and alter table attributes #56290

joechenrh commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

codecov bot commented Sep 26, 2024 •

edited

Loading

D3Hunter Sep 27, 2024

D3Hunter left a comment

joccau left a comment

joccau left a comment

ti-chi-bot bot commented Sep 29, 2024

ti-chi-bot bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

ddl: arg v2 for flashback cluster and alter table attributes #56290

ddl: arg v2 for flashback cluster and alter table attributes #56290

Conversation

joechenrh commented Sep 25, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Sep 25, 2024

codecov bot commented Sep 26, 2024 • edited Loading

Codecov Report

D3Hunter Sep 27, 2024

Choose a reason for hiding this comment

D3Hunter left a comment

Choose a reason for hiding this comment

joccau left a comment

Choose a reason for hiding this comment

joccau left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 29, 2024

ti-chi-bot bot commented Sep 29, 2024

[LGTM Timeline notifier]

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

D3Hunter commented Sep 29, 2024

tiprow bot commented Sep 29, 2024

codecov bot commented Sep 26, 2024 •

edited

Loading